Page MenuHomePhabricator

VisualEditor hCaptcha: Warning returned in the API response about unrecognised parameter "wgConfirmEditForceShowCaptcha"
Closed, ResolvedPublicBUG REPORT

Description

Summary

The VisualEditor Bot detection and mitigation (WE4.2 hCaptcha editing trial) integration currently causes a unrecognizedparams warning for the wgConfirmEditForceShowCaptcha parameter when an AbuseFilter filter has force shown a captcha

Steps to reproduce

  1. Create an AbuseFilter filter that has a consequence to show a captcha and make it trigger for a test edit
  2. Trigger this filter by making an edit via the VisualEditor interface, while having the network tab open with persist logs enabled
  3. Complete any visual challenge that is shown
  4. Look at the MediaWiki API request for the visualeditoredit API that is a POST request
  5. Inspect the response

What happens

The unrecognizedparams key is set as a warning which includes the parameter wgConfirmEditForceShowCaptcha

image.png (1,091×277 px, 53 KB)

What should have happened instead

The wgConfirmEditForceShowCaptcha parameter should not be included in this warning list

Acceptance criteria

  • The wgConfirmEditForceShowCaptcha parameter is recognised by the visualeditoredit API and no warning about it is created

Event Timeline

Change #1275915 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/VisualEditor@master] VisualEditor: Warning returned in the API response

https://gerrit.wikimedia.org/r/1275915

Change #1275915 abandoned by Mpostoronca:

[mediawiki/extensions/VisualEditor@master] VisualEditor: Warning returned in the API response

https://gerrit.wikimedia.org/r/1275915

Change #1276689 had a related patch set uploaded (by Mpostoronca; author: Mpostoronca):

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Register params for the visualeditoredit API module

https://gerrit.wikimedia.org/r/1276689

Change #1276689 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Register params for the visualeditoredit API module

https://gerrit.wikimedia.org/r/1276689

dom_walden subscribed.

I have not seen this error anymore, although I have not been monitoring it consistently.

Checked on test wiki, it does not happen anymore