Maniphest T423842

EditCheck CSS affects unrelated dialogs in VisualEditor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	thiemowmde
	Apr 20 2026, 8:23 AM

Project Tags

Referenced Files

	F76743729: Screenshot from 2026-04-20 10-14-06.png
	Apr 20 2026, 8:23 AM

Subscribers

Description

I found that a piece of CSS from EditCheck is interfering with dialogs like the Cite editor, image dialog, and others.

Screenshot from 2026-04-20 10-14-06.png (1,197×553 px, 157 KB)

This is the problematic CSS: https://phabricator.wikimedia.org/diffusion/EVED/browse/master/editcheck/modules/EditCheck.less#L550

The selector is not specific enough and also affects unrelated surfaces that are inside dialogs.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Editcheck: Scope mobile css to avoid TargetWidgets in dialogs	mediawiki/extensions/VisualEditor	master	+2 -2

Customize query in gerrit

Event Timeline

thiemowmde created this task.Apr 20 2026, 8:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2026, 8:23 AM

thiemowmde added projects: VisualEditor, Editing-team.Apr 20 2026, 8:24 AM

thiemowmde removed a project: Cite.

Change #1281487 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Editcheck: Scope mobile css to avoid TargetWidgets in dialogs

https://gerrit.wikimedia.org/r/1281487

gerritbot added a project: Patch-For-Review.May 1 2026, 12:51 PM

DLynch claimed this task.May 1 2026, 1:08 PM

DLynch added a project: Wikimedia-Hackathon-2026.

Aklapper moved this task from Backlog to Proposed Projects on the Wikimedia-Hackathon-2026 board.May 1 2026, 8:09 PM

thiemowmde added a project: WMDE-TechWish-Sprint-2026-04-27-Multicolor-Potatoes.May 4 2026, 5:38 AM

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2026-04-27-Multicolor-Potatoes board.

Change #1281487 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Editcheck: Scope mobile css to avoid TargetWidgets in dialogs

https://gerrit.wikimedia.org/r/1281487

Maintenance_bot removed a project: Patch-For-Review.May 6 2026, 4:31 PM

DLynch closed this task as Resolved.May 6 2026, 4:54 PM

DLynch added projects: Skipped QA, OKR-Work.

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 6 2026, 5:00 PM