shareHighlight - if headers were highlighlited, Share card shows "edit" word
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Etonkovidova
	Apr 16 2026, 9:17 PM

Project Tags

Referenced Files

	F81260216: Screenshot 2026-05-13 at 4.13.20 PM.png
	Wed, May 13, 8:59 PM

	F81260298: Screenshot 2026-05-13 at 4.13.45 PM.png
	Wed, May 13, 8:59 PM

	F81259844: Screenshot 2026-05-13 at 4.49.57 PM.png
	Wed, May 13, 8:59 PM

	F81259819: Screenshot 2026-05-13 at 4.49.14 PM.png
	Wed, May 13, 8:59 PM

	F81259720: Screenshot 2026-05-13 at 4.48.48 PM.png
	Wed, May 13, 8:59 PM

	F80335157: image.png
	May 8 2026, 6:26 PM

	F80335188: image.png
	May 8 2026, 6:26 PM

	F79969776: image.png
	May 6 2026, 11:03 PM

Subscribers

Description

Some non-content text (e.g. "edit" link, footnote links, ...) gets included in the selected text.
While we may need those in the share url, we do not want them to be included in shared output.

Steps to replicate the issue:

On itwiki go to https://it.wikipedia.org/wiki/Charlie_Parker?shareHighlight=1&uselang=en
Highlight any header with some content around it, see the example below:

Screenshot 2026-04-16 at 5.07.29 PM.png (786×1,728 px, 314 KB)

What happens?:

the Share card for the text highlighted in the content in the screenshot above will incorrectly shows
- the lead image (filed as /T423603)
- and the word edit (the edit icon was inadvertently included into the highlighted text)

Screenshot 2026-04-16 at 5.07.42 PM.png (800×1,742 px, 611 KB)

What should have happened instead?:

a Share card should show only user-visible content

Acceptance criteria

non-content text (e.g. "edit" link, footnote links, ...) is still included in the share url as needed
- broken in current patch; fix planned to return two forms of the text, with and without exclusions
non-content text (e.g. "edit" link, footnote links, ...) is not included in the shared output
- done in current patch

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[Share Highlight] Exclude section edit links, footnotes from selection	mediawiki/extensions/ReaderExperiments	wmf/1.47.0-wmf.2	+125 -62
	[Share Highlight] Exclude section edit links, footnotes from selection	mediawiki/extensions/ReaderExperiments	master	+125 -62

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T416432 [Epic] Share Card experiment
Resolved		KSarabia-WMF	T424591 [Share Highlights] Bug Bash
Resolved	BUG REPORT	egardner	T423658 shareHighlight - if headers were highlighlited, Share card shows "edit" word

Event Timeline

Etonkovidova created this task.Apr 16 2026, 9:17 PM

Restricted Application added projects: FY2025-26 WE3.1 Engaging New Audiences, Reader Growth Team. · View Herald TranscriptApr 16 2026, 9:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

mfossati added a parent task: T416432: [Epic] Share Card experiment.Apr 20 2026, 11:08 AM

mfossati moved this task from Incoming/Inbox to Needs Refinement on the Reader Growth Team board.

matthiasmullie set the point value for this task to 2.Apr 21 2026, 5:03 PM

matthiasmullie updated the task description. (Show Details)Apr 21 2026, 5:46 PM

SherryYang-WMF triaged this task as High priority.Apr 27 2026, 10:49 PM

SherryYang-WMF added a parent task: T424591: [Share Highlights] Bug Bash.Apr 27 2026, 10:55 PM

SherryYang-WMF moved this task from Needs Refinement to Sprint 3 (Apr 29 - May 12) Q4 25/26 on the Reader Growth Team board.Apr 29 2026, 12:04 AM

SherryYang-WMF edited projects, added: Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26); removed: Reader Growth Team.

lwatson removed a parent task: T416432: [Epic] Share Card experiment.May 6 2026, 12:44 PM

bvibber claimed this task.May 6 2026, 10:06 PM

bvibber moved this task from Committed to Doing on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.

This appears to have been reduced but not fully eliminated by the patch for T421160 (selection edge cases) -- ensuring that we only take from a single block element means we can only end up with the "edit" button if the user has managed to select _none_ of the section title (which is an <h2> or sometimes <h1>) and _has_ gotten the selection onto the <span> with the edit link, outside the h2.

Setting user-select: none on .mw-editsection appears to handily exclude the section edit links from the selection, and therefore any remaining edge cases where we would extract that text. (And if we later change to allow scraping across block levels, it will still work without needing to be changed.)

This also has the bonus of excluding the "edit" links from copy/paste of text across heading boundaries, where no user has ever wanted it. ;) So this might be something to more to core later.

Change #1284018 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/ReaderExperiments@master] [Share Highlight] Excluse section edit links from selection

https://gerrit.wikimedia.org/r/1284018

gerritbot added a project: Patch-For-Review.May 6 2026, 11:03 PM

bvibber moved this task from Doing to Code Review on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 6 2026, 11:10 PM

bvibber updated the task description. (Show Details)May 7 2026, 10:41 PM

About to push new patchset which handles the exclusions without breaking fragments :D

bvibber removed bvibber as the assignee of this task.May 11 2026, 10:18 PM

bvibber subscribed.

bvibber unsubscribed.

egardner claimed this task.May 12 2026, 4:04 PM

egardner moved this task from Code Review to QA on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.May 12 2026, 7:31 PM

Change #1284018 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] [Share Highlight] Exclude section edit links, footnotes from selection

https://gerrit.wikimedia.org/r/1284018

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 12 2026, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 12 2026, 8:31 PM

Change #1286518 had a related patch set uploaded (by Jdlrobson; author: Brooke Vibber):

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] [Share Highlight] Exclude section edit links, footnotes from selection

https://gerrit.wikimedia.org/r/1286518

gerritbot added a project: Patch-For-Review.May 12 2026, 10:21 PM

Change #1286518 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.47.0-wmf.2] [Share Highlight] Exclude section edit links, footnotes from selection

https://gerrit.wikimedia.org/r/1286518

Mentioned in SAL (#wikimedia-operations) [2026-05-13T13:27:13Z] <mfossati@deploy1003> Started scap sync-world: Backport for [[gerrit:1286518|[Share Highlight] Exclude section edit links, footnotes from selection (T423658)]], [[gerrit:rEWBA128683823dcc|Add robust color fallbacks for QuoteCard average-color styling (T425358)]], [[gerrit:1286839|Fixed card width (T425710)]], [[gerrit:1286844|Adjust image size to match fixed width (T425710)]], [[gerrit:1286846|ShareHighlight: exclude browsers th

Mentioned in SAL (#wikimedia-operations) [2026-05-13T13:29:09Z] <mfossati@deploy1003> jdlrobson, mfossati: Backport for [[gerrit:1286518|[Share Highlight] Exclude section edit links, footnotes from selection (T423658)]], [[gerrit:rEWBA128683823dcc|Add robust color fallbacks for QuoteCard average-color styling (T425358)]], [[gerrit:1286839|Fixed card width (T425710)]], [[gerrit:1286844|Adjust image size to match fixed width (T425710)]], [[gerrit:1286846|ShareHighlight: exclude browsers that d

Maintenance_bot removed a project: Patch-For-Review.May 13 2026, 1:31 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-13T13:40:29Z] <mfossati@deploy1003> Finished scap sync-world: Backport for [[gerrit:1286518|[Share Highlight] Exclude section edit links, footnotes from selection (T423658)]], [[gerrit:rEWBA128683823dcc|Add robust color fallbacks for QuoteCard average-color styling (T425358)]], [[gerrit:1286839|Fixed card width (T425710)]], [[gerrit:1286844|Adjust image size to match fixed width (T425710)]], [[gerrit:1286846|ShareHighlight: exclude browsers t

ReleaseTaggerBot edited projects, added: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).May 13 2026, 2:00 PM

HSwan-WMF moved this task from QA to Signoff on the Reader Growth Team (Sprint 3 (Apr 29 - May 12) Q4 25/26) board.Wed, May 13, 4:08 PM

Checked on itwiki wmf.2 - the issue is fixed. The specific article in the task descirption - https://it.wikipedia.org/wiki/Charlie_Parker?shareHighlight=1&uselang=en will display "TypeError: parsedUrl.resizeUrl is not a function" (T425149 ) , Checked other articles:

Below are the screenshots showing the correct share card text despite highlighting (selecting) across sections. Also, the references are also not included in a share card:

Screenshot 2026-05-13 at 4.48.48 PM.png (1,458×1,638 px, 480 KB)

Screenshot 2026-05-13 at 4.49.14 PM.png (1,292×1,432 px, 349 KB)

Screenshot 2026-05-13 at 4.49.57 PM.png (2,150×1,624 px, 1021 KB)

//Note:// There are still edge cases when non-user visible context is displayed. Should be there a follow-up task specifically for edge cases?
-https://it.wikipedia.org/wiki/Campionato_mondiale_di_beach_soccer_2024?shareHighlight=1&uselang=en

Screenshot 2026-05-13 at 4.13.45 PM.png (2,076×1,782 px, 528 KB)

Screenshot 2026-05-13 at 4.13.20 PM.png (856×1,152 px, 128 KB)

Thanks @Etonkovidova! Please file the edge cases, like the hatnote, in a new ticket.

In T423658#11920224, @lwatson wrote:

Thanks @Etonkovidova! Please file the edge cases, like the hatnote, in a new ticket.

@Etonkovidova filed in T426308: [Share Highlights] Share card display edge cases.

shareHighlight - if headers were highlighlited, Share card shows "edit" wordClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions