Page MenuHomePhabricator

Suggestion counter doesn't show if suggestions were turned off in previous session
Closed, ResolvedPublic

Description

  1. Turn off suggestions on a page that has suggestions
  2. Reload the editor

Observe that the suggestion counter doesn't show in the toolbar

Also when suggestions are hidden from an intially visible state, the counter will not update if issues are resolved by editing.

Event Timeline

As a performance note, this requires continually computing all suggestions (including expensive ones such as ToneCheck) for users who have turned suggestions off (and may have no intention of ever turning it on again).

Change #1271711 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Compute suggestions when available but hidden

https://gerrit.wikimedia.org/r/1271711

Change #1271711 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Compute suggestions when available but hidden

https://gerrit.wikimedia.org/r/1271711