Page MenuHomePhabricator

LanguageConverter doesn't convert inside <indicator>
Closed, ResolvedPublic

Description

Compare
https://crh.wikipedia.org/wiki/Roma?useparsoid=0&variant=crh-cyrl

image.png (516×148 px, 22 KB)

and
https://crh.wikipedia.org/wiki/Roma?useparsoid=1&variant=crh-cyrl&parsoidnewlc=1
image.png (516×148 px, 17 KB)

Parsoid is not language converting to Cyrillic inside the <indicator> (the lat/long). The indicator beside it also have -{ .. }- markup which isn't being converted so appears to be missing.

Event Timeline

Change #1270120 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: use ContentHolder to hold indicator HTML

https://gerrit.wikimedia.org/r/1270120

Change #1270122 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParsoidLanguageConverter: convert inside <indicator>

https://gerrit.wikimedia.org/r/1270122

Change #1270122 merged by jenkins-bot:

[mediawiki/core@master] ParsoidLanguageConverter: convert inside <indicator>

https://gerrit.wikimedia.org/r/1270122

Change #1271030 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@wmf/1.46.0-wmf.24] ParsoidLanguageConverter: convert inside <indicator>

https://gerrit.wikimedia.org/r/1271030

Change #1271030 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.24] ParsoidLanguageConverter: convert inside <indicator>

https://gerrit.wikimedia.org/r/1271030

Mentioned in SAL (#wikimedia-operations) [2026-04-14T20:30:12Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1271030|ParsoidLanguageConverter: convert inside <indicator> (T422961)]], [[gerrit:1271038|LanguageConverter: Allow disabling top-level variant "guess" (T419328)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-14T20:32:00Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1271030|ParsoidLanguageConverter: convert inside <indicator> (T422961)]], [[gerrit:1271038|LanguageConverter: Allow disabling top-level variant "guess" (T419328)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-14T20:40:31Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1271030|ParsoidLanguageConverter: convert inside <indicator> (T422961)]], [[gerrit:1271038|LanguageConverter: Allow disabling top-level variant "guess" (T419328)]] (duration: 10m 18s)