While for core, the list of callsites is _kind of_ limited, extensions are a different story:
https://codesearch.wmcloud.org/deployed/?q=RequestContext%3A%3AgetMain&files=%5C.php&excludeFiles=phpunit
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T422741 Reduce uses of RequestContext::getMain in MediaWiki code | |||
| Open | None | T422746 Reduce use of RequestContext::getMain in WMF-deployed extensions | |||
| Resolved | MGChecker | T423038 Remove HTMLFormField context fallbacks | |||
| Open | None | T423283 Pass context to GetPreferences hook | |||
| Open | None | T423456 Replace RequestContext::getMain in DonationInterface extension | |||
| Open | None | T427009 Pass context to LogEventsList::showLogExtract() |
Event Timeline
Comment Actions
Change #1270137 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/Collection@master] Remove only use of global context
Comment Actions
Change #1260041 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/FlaggedRevs@master] Avoid accessing main context and replace wgLang
Comment Actions
Change #1270151 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/wikihiero@master] Remove only use of global context
Comment Actions
Change #1270152 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/Wikisource@master] Replace only use of main context
Comment Actions
Change #1270153 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/WikimediaMaintenance@master] Replace only use of main context
Comment Actions
In Collection and FlaggedRevs the context objects were not far away (even though in FlaggedRevs are some left over), in the other three extensions RequestContext was used exclusively to access the config.
WikimediaIncubator and GlobalCssJs also look rather easy, I will take a look at that once I have a bit more time.
Comment Actions
Change #1270152 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] Replace only use of main context
Comment Actions
Change #1270151 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Remove only use of global context
Comment Actions
Change #1270153 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Replace only use of main context
Comment Actions
Change #1270137 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Remove only use of global context
Comment Actions
Just to have a mark for future progress, on 12/04 codesearch showed 432 files using RequestContext::getMain outside phpunit.
Comment Actions
Change #1271094 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/WikimediaIncubator@master] Replace uses of main context
Comment Actions
Change #1260041 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Avoid accessing main context and replace wgLang
Comment Actions
Change #1272725 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/Calendar@master] Use more robust approach to determine language
Comment Actions
Change #1272789 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/TimedMediaHandler@master] Avoid use of RequestContext in getDimensionsString
Comment Actions
Change #1272844 had a related patch set uploaded (by MGChecker; author: hgasuser@gmail.com):
[mediawiki/extensions/FileImporter@master] Replace uses of main context
Comment Actions
Change #1271094 merged by jenkins-bot:
[mediawiki/extensions/WikimediaIncubator@master] Reduce use of main context
Comment Actions
Change #1272789 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Avoid use of RequestContext in getDimensionsString
Comment Actions
Change #1282043 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/Collection@master] Pass context source to Suggest and replace RequestContext::getMain()
Comment Actions
Change #1282435 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/MediaSearch@master] Replace only use of RequestContext::getMain
Comment Actions
Change #1282433 had a related patch set uploaded (by MGChecker; author: MGChecker):
[mediawiki/extensions/WikiLambda@master] Use DifferenceEngine::getContext instead of RequestContext
Comment Actions
Change #1282433 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Use DifferenceEngine::getContext instead of RequestContext
Comment Actions
Change #1282435 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@master] Replace only use of RequestContext::getMain
Comment Actions
Change #1282043 abandoned by Umherirrender:
[mediawiki/extensions/Collection@master] Pass context source to Suggest and replace RequestContext::getMain()
Reason:
Code under refactor, which also address this issue
Comment Actions
Change #1272844 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Replace uses of main context
Comment Actions
Change #1298725 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):
[mediawiki/extensions/Collection@master] refactor: Remove reliance on global session and request