Make AttributionDataBuilder into a MediaWiki service via service wiring
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	aaron
	Apr 7 2026, 2:44 PM

Project Tags

Referenced Files

None

Subscribers

aaron

Aklapper

Atieno

Description

Originally T417672.

It would be increasingly useful to make the AttributionDataBuilder a service and inject it into the Handler class instead of making the Handler class have to handle constructing an increasing number of dependencies to pass to AttributionDataBuilder::__construct(). This came up in several places, including https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaCustomizations/+/1265557 .

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Attribution: AttributionDataBuilder becomes a service	mediawiki/extensions/WikimediaCustomizations	master	+36 -39

Customize query in gerrit

Related Objects

Mentioned In: T421891: Create Attribution API endpoint for requesting general project information
Mentioned Here: T421891: Create Attribution API endpoint for requesting general project information
T417672: Refactor the business logic out of the AttributionRestHandler

Event Timeline

aaron created this task.Apr 7 2026, 2:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2026, 2:44 PM

BPirkle triaged this task as Medium priority.Apr 7 2026, 10:09 PM

BPirkle moved this task from Incoming (Needs Triage) to Backlog on the MW-Interfaces-Team board.

Picking this up as part of T421891 so the new Handler injects the builder as a service

Atieno claimed this task.Apr 9 2026, 7:54 AM

Atieno moved this task from Backlog to MWI-Sprint-31 (2026-04-07 to 2026-04-21) on the MW-Interfaces-Team board.

Atieno edited projects, added: MW-Interfaces-Team (MWI-Sprint-31 (2026-04-07 to 2026-04-21)); removed: MW-Interfaces-Team.

Atieno moved this task from Committed to In Progress on the MW-Interfaces-Team (MWI-Sprint-31 (2026-04-07 to 2026-04-21)) board.

Atieno moved this task from In Progress to Committed on the MW-Interfaces-Team (MWI-Sprint-31 (2026-04-07 to 2026-04-21)) board.Apr 9 2026, 4:07 PM

Idea is to optimize handler by passing the data builder as a service.
The data builder is currently extremely hard coded to page signals. A possible follow up is to generalize the builder for other use cases like site signals.
The tracer will also have to be passed since it is per request

Atieno mentioned this in T421891: Create Attribution API endpoint for requesting general project information.Apr 14 2026, 2:55 PM

Atieno reassigned this task from Atieno to pmiazga.Apr 14 2026, 5:12 PM

Atieno moved this task from Committed to In Progress on the MW-Interfaces-Team (MWI-Sprint-31 (2026-04-07 to 2026-04-21)) board.

Change #1270990 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/extensions/WikimediaCustomizations@master] Attribution: AttributionDataBuilder becomes a service

https://gerrit.wikimedia.org/r/1270990

gerritbot added a project: Patch-For-Review.Apr 14 2026, 7:07 PM

pmiazga moved this task from In Progress to Code Review on the MW-Interfaces-Team (MWI-Sprint-31 (2026-04-07 to 2026-04-21)) board.Apr 14 2026, 7:08 PM

Change #1270990 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Attribution: AttributionDataBuilder becomes a service

https://gerrit.wikimedia.org/r/1270990

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2026, 1:31 PM