Page MenuHomePhabricator

VisualEditor hCaptcha: Instrument the VisualEditor integration
Closed, ResolvedPublic

Description

Summary

The VisualEditor Bot detection and mitigation (WE4.2 hCaptcha editing trial) integration needs to be instrumented so that we can see the effects of enabling hCaptcha in that interface

Acceptance criteria

  • Sufficient instrumentation exists on the integration (both the on load and save error handlers)
  • This instrumentation is displayed somewhere

Event Timeline

OKryva-WMF added a subscriber: STran.

Change #1271791 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.hCaptcha.utils.js: Split renderHCaptchaWithTracking

https://gerrit.wikimedia.org/r/1271791

Change #1271792 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.hCaptcha/utils.js: Allow Element as container

https://gerrit.wikimedia.org/r/1271792

Change #1271793 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ConfirmEdit@master] VisualEditor hCaptcha: Use renderHCaptcha instead of hcaptcha.render

https://gerrit.wikimedia.org/r/1271793

We will be reusing the existing instrumentation defined in utils.js for the wikitext editor. This is already displayed in a Grafana dashboard and I've updated it to show this info for VisualEditor / MobileFrontend for edits

The patches for review make the rendering of hCaptcha use the utils.js code for this which is instrumented. The rest of the VisualEditor integration already is instrumented for loading hCaptcha and executing it

Change #1271791 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.hCaptcha/utils.js: Split renderHCaptchaWithTracking

https://gerrit.wikimedia.org/r/1271791

Change #1271792 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] ext.confirmEdit.hCaptcha/utils.js: Allow Element as container

https://gerrit.wikimedia.org/r/1271792

Change #1271793 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] VisualEditor hCaptcha: Use renderHCaptcha instead of hcaptcha.render

https://gerrit.wikimedia.org/r/1271793