Page MenuHomePhabricator

Image download button text cut off in DEWP
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open an image in a Wikipedia article in German Wikipedia by clicking on it
  • Click the download button in the bottom right corner
  • See the blue download button

What happens?:
It looks like in the screenshots (text/icon cut off):

f1.png (498×187 px, 21 KB)
f2.png (516×157 px, 20 KB)

What should have happened instead?:
The blue box should be larger so the text fits on it.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Maybe the text in the dropdown box "Originaldatei (2048…" should also be fixed so as to not be cut off at the bottom.

Event Timeline

@Prototyperspective I tried to reproduce it but wasn't able to reproduce the bug you showed in the Image, if possible can you specify the browser/device you were using and if found in any article , please specify so it can analysed. Thanks!

Steps to reproduce: Select "large" as a text size in the appearance menu. Make sure your user language is German (e.g. by being logged-out on dewiki) -> Text size in MediaViewer buttons increases as well and leads to the issue reported in this task.

Thanks @Johannnes89 , I'm able to reproduce it. Will try to fix and raise PR for it

Change #1263897 had a related patch set uploaded (by Praffq; author: Praffq):

[mediawiki/extensions/MultimediaViewer@master] fixed the overflowing issue with the download button

https://gerrit.wikimedia.org/r/1263897

I pushed the fix to gerrit (This is my first time using gerrit , please let me know if I did something wrong).

After fix -

image.png (516×443 px, 52 KB)

Thanks! Amazing to see such a fast reaction and a new dev getting started on MediaWiki issues (much development needed here). However, I have text size set to Small in the appearance settings so I don't know whether this fixes it nevertheless. The issue exists even if I change font size to standard. Maybe it's some browser font-size thing (Firefox).

@Prototyperspective I'm using Arc browser (chromium extension) and was able to reproduce it with the font set to "large" only, else it ws working alright. I'll try to reproduce the case you mentioned using firefox browser, and will try to fix it for the specific as well

Update:- Checked on firefox for all text sizes, everything works as expected after the fix.

(I think maybe the browser was using cached data to load the css, or maybe checking on wrong deployment)

Change #1263897 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] fixed the overflowing issue with the download button

https://gerrit.wikimedia.org/r/1263897

TheDJ subscribed.

Should land on wikimedia wikis next week. Thank you @Praffq !