Page MenuHomePhabricator

Hide “recent changes by this application” links for owner-only consumers
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:OAuthListConsumers
  • Find an owner-only consumer
  • Click its “recent changes by this application” link

What happens?:
You will be sent to a Special:RecentChanges page with an OAuth CID: 1234 tag filter. No changes will be listed, because edits (and patrols) using owner-only consumers aren’t tagged (just like bot password authentication doesn’t produce change tags either). In fact, the change tag doesn’t exist, and so if you try to change the RecentChanges parameters (e.g. select a longer period), it’ll silently drop the tag filter and show you arbitrary unfiltered changes, which is misleading (they have nothing to do with the OAuth consumer you were looking at).

What should have happened instead?:
Given that the link is useless, we should just skip showing it, IMHO.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1262170 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/extensions/OAuth@master] Hide recent changes link for owner-only consumers

https://gerrit.wikimedia.org/r/1262170

Change #1262170 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Hide recent changes link for owner-only consumers

https://gerrit.wikimedia.org/r/1262170

LucasWerkmeister claimed this task.
LucasWerkmeister moved this task from Uncategorized to UI/UX on the MediaWiki-extensions-OAuth board.

Seems to work on Beta (and individual consumers) \o/