Page MenuHomePhabricator
Create Task
Maniphest T420722

accountJustCreated flag not properly added on WelcomeSurvey redirections
Closed, ResolvedPublic
Actions

Description

@Milimetric reported that the $returnToQuery = 'accountJustCreated=1'; code added in rEGREa1df3b881a8638071d180a38a8994de02a663909 is buggy and he’s not able to get a wgTKAccountJustCreated = "1"  on the first page load after account creation.

Steps to replicate the issue (include links if applicable):

  • Go to Special:CreateAccount in testwiki (make sure no returnto param is present in the URL)
  • Place a breakpoint on line 7 of WikimediaEvents/modules/ext.wikimediaEvents/accountCreation.js  where we check mw.config.get( 'wgTKAccountJustCreated' )
  • Observe null , the correct value should be "1"

What happens?:
There's no "account just created" signal on the first page load (Special:WelcomeSurvey) after account creation

What should have happened instead?:

mw.config.get( 'wgTKAccountJustCreated' ) should be set with a value of "1"

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Introduced in wmf/1.46.0-wmf.19

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
fix(WelcomeSurveyHooks): ensure accountJustCreated is added oncemediawiki/extensions/GrowthExperimentsmaster+77 -11
AccountCreationHandler: add accountJustCreated url param oncemediawiki/extensions/WikimediaEventsmaster+145 -0
tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirectmediawiki/extensions/GrowthExperimentsmaster+188 -6
fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2mediawiki/extensions/GrowthExperimentsmaster+22 -19
fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2mediawiki/extensions/GrowthExperimentswmf/1.46.0-wmf.20+22 -19
tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirectmediawiki/extensions/GrowthExperimentswmf/1.46.0-wmf.20+188 -6
fix(WelcomeSurveyHooks): ensure accountJustCreated is always addedmediawiki/extensions/GrowthExperimentswmf/1.46.0-wmf.20+16 -7
fix(WelcomeSurveyHooks): ensure accountJustCreated is always addedmediawiki/extensions/GrowthExperimentsmaster+16 -7
Customize query in gerrit

Related Objects

Event Timeline

Sgs created this task.Mar 20 2026, 12:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2026, 12:20 PM
Sgs updated the task description. (Show Details)Mar 20 2026, 12:32 PM
gerritbot added a comment.Mar 20 2026, 12:33 PM

Change #1256373 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added

https://gerrit.wikimedia.org/r/1256373

Sgs moved this task from Inbox to FY2025-26 Q3 Sprint 5 on the Growth-Team board.Mar 20 2026, 12:33 PM
Sgs edited projects, added: Growth-Team (FY2025-26 Q3 Sprint 5); removed: Growth-Team.
gerritbot added a project: Patch-For-Review.Mar 20 2026, 12:34 PM
Sgs triaged this task as High priority.Mar 20 2026, 12:34 PM
Sgs moved this task from Incoming to Code Review on the Growth-Team (FY2025-26 Q3 Sprint 5) board.
Michael subscribed.Mar 20 2026, 1:42 PM
ldelench_wmf added a project: OKR-Work.Mar 20 2026, 5:33 PM
gerritbot added a comment.Mar 20 2026, 5:53 PM

Change #1256373 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added

https://gerrit.wikimedia.org/r/1256373

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 20 2026, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 20 2026, 6:31 PM
gerritbot added a comment.Mar 20 2026, 7:07 PM

Change #1256489 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect

https://gerrit.wikimedia.org/r/1256489

gerritbot added a project: Patch-For-Review.Mar 20 2026, 7:07 PM
gerritbot added a comment.Mar 20 2026, 8:06 PM

Change #1256514 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2

https://gerrit.wikimedia.org/r/1256514

gerritbot added a comment.Mar 23 2026, 9:52 AM

Change #1256489 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect

https://gerrit.wikimedia.org/r/1256489

gerritbot added a comment.Mar 23 2026, 9:54 AM

Change #1256514 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2

https://gerrit.wikimedia.org/r/1256514

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2026, 10:31 AM
gerritbot added a comment.Mar 23 2026, 11:38 AM

Change #1259035 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added

https://gerrit.wikimedia.org/r/1259035

gerritbot added a project: Patch-For-Review.Mar 23 2026, 11:38 AM

Change #1259036 had a related patch set uploaded (by Sergio Gimeno; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect

https://gerrit.wikimedia.org/r/1259036

gerritbot added a comment.Mar 23 2026, 12:06 PM

Change #1259036 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect

Reason:

merge conflicts, wrong base

https://gerrit.wikimedia.org/r/1259036

gerritbot added a comment.Mar 23 2026, 12:06 PM

Change #1259036 restored by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect

https://gerrit.wikimedia.org/r/1259036

gerritbot added a comment.Mar 23 2026, 12:07 PM

Change #1259046 had a related patch set uploaded (by Sergio Gimeno; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2

https://gerrit.wikimedia.org/r/1259046

gerritbot added a comment.Mar 23 2026, 12:57 PM

Change #1259072 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(WelcomeSurveyHooks): ensure accountJustCreated is added once

https://gerrit.wikimedia.org/r/1259072

gerritbot added a comment.Mar 23 2026, 12:57 PM

Change #1259073 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikimediaEvents@master] AccountCreationHandler: add accountJustCreated url param once

https://gerrit.wikimedia.org/r/1259073

gerritbot added a comment.Mar 23 2026, 1:05 PM

Change #1259035 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added

https://gerrit.wikimedia.org/r/1259035

gerritbot added a comment.Mar 23 2026, 1:05 PM

Change #1259036 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect

https://gerrit.wikimedia.org/r/1259036

gerritbot added a comment.Mar 23 2026, 1:05 PM

Change #1259046 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.46.0-wmf.20] fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2

https://gerrit.wikimedia.org/r/1259046

Stashbot added a comment.Mar 23 2026, 1:05 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-23T13:05:55Z] <sgimeno@deploy2002> Started scap sync-world: Backport for [[gerrit:1259035|fix(WelcomeSurveyHooks): ensure accountJustCreated is always added (T420722)]], [[gerrit:1259036|tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect (T420722)]], [[gerrit:1259046|fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2 (T420722)]]

Stashbot added a comment.Mar 23 2026, 1:07 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-23T13:07:42Z] <sgimeno@deploy2002> sgimeno: Backport for [[gerrit:1259035|fix(WelcomeSurveyHooks): ensure accountJustCreated is always added (T420722)]], [[gerrit:1259036|tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect (T420722)]], [[gerrit:1259046|fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2 (T420722)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Ch

Stashbot added a comment.Mar 23 2026, 1:17 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-23T13:17:39Z] <sgimeno@deploy2002> Finished scap sync-world: Backport for [[gerrit:1259035|fix(WelcomeSurveyHooks): ensure accountJustCreated is always added (T420722)]], [[gerrit:1259036|tests: add coverage for WelcomeSurveyHooks::onCentralAuthPostLoginRedirect (T420722)]], [[gerrit:1259046|fix(WelcomeSurveyHooks): ensure accountJustCreated is always added 2 (T420722)]] (duration: 11m 43s)

Sgs moved this task from Code Review to QA on the Growth-Team (FY2025-26 Q3 Sprint 5) board.Mar 23 2026, 1:57 PM
Sgs moved this task from QA to Test in Production on the Growth-Team (FY2025-26 Q3 Sprint 5) board.
Sgs moved this task from Test in Production to QA on the Growth-Team (FY2025-26 Q3 Sprint 5) board.
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 23 2026, 2:00 PM
Michael edited projects, added: Growth-Team (FY2025-26 Q3 Sprint 6); removed: Growth-Team (FY2025-26 Q3 Sprint 5).Mar 24 2026, 4:18 PM
Michael moved this task from Incoming to QA on the Growth-Team (FY2025-26 Q3 Sprint 6) board.
gerritbot added a comment.Mar 25 2026, 4:20 PM

Change #1259072 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(WelcomeSurveyHooks): ensure accountJustCreated is added once

https://gerrit.wikimedia.org/r/1259072

gerritbot added a comment.Mar 25 2026, 4:20 PM

Change #1259073 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] AccountCreationHandler: add accountJustCreated url param once

https://gerrit.wikimedia.org/r/1259073

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31); removed: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 25 2026, 5:00 PM
Etonkovidova closed this task as Resolved.Apr 1 2026, 10:08 PM
Etonkovidova subscribed.

Tested on testwiki wmf.22 - seems to be working as expected.
Note: Technically, testwiki doesn't have Create Account page. When Special:Create Account page is searched, it redirects to
https:auth.wikimedia.org/testwiki/w/index.php?title=Special:CreateAccount

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits