Page MenuHomePhabricator
Create Task
Maniphest T420712

Revise Tone: remove secondary highlighted text elements from the revising state
Closed, ResolvedPublic
Actions

Description

When revising text in the Revise Tone check/suggestion, highlights from other unselected checks or suggestions may appear if they are within the same text block.

image (27).png (2,852×654 px, 308 KB)

During this state, only the active revision styling (blue borders) should be visible, as the user is focused on editing the text.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
EditCheck: Supress intersecting selections when revisingmediawiki/extensions/VisualEditormaster+10 -0
Customize query in gerrit

Event Timeline

bmartinezcalvo created this task.Mar 20 2026, 10:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2026, 10:16 AM
gerritbot added a comment.Mar 20 2026, 11:42 AM

Change #1256350 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Supress intersecting selections when revising

https://gerrit.wikimedia.org/r/1256350

gerritbot added a project: Patch-For-Review.Mar 20 2026, 11:42 AM
ppelberg edited projects, added: Editing-team (Editing-Q4-30Mar-10Apr-2026); removed: Editing-team.Mar 20 2026, 8:47 PM
ppelberg added a project: OKR-Work.
ppelberg moved this task from Decision to be made to Code Review on the Editing-team (Editing-Q4-30Mar-10Apr-2026) board.
VPuffetMichel edited projects, added: Editing-team (Editing-18Mar-27Mar-2026); removed: Editing-team (Editing-Q4-30Mar-10Apr-2026).Mar 25 2026, 9:49 PM
VPuffetMichel moved this task from Decisions to be made to Code Review on the Editing-team (Editing-18Mar-27Mar-2026) board.
DLynch assigned this task to Esanders.Mar 30 2026, 5:10 PM
DLynch edited projects, added: Editing-team (Editing-Q4-30Mar-10Apr-2026); removed: Editing-team (Editing-18Mar-27Mar-2026).
DLynch moved this task from Code Review to QA on the Editing-team (Editing-Q4-30Mar-10Apr-2026) board.Mar 30 2026, 5:24 PM
DLynch added a project: Editing QA.
gerritbot added a comment.Mar 30 2026, 5:24 PM

Change #1256350 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Supress intersecting selections when revising

https://gerrit.wikimedia.org/r/1256350

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2026, 5:30 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 30 2026, 6:00 PM
Ryasmeen closed this task as Resolved.Apr 1 2026, 9:42 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Editing-Q4-30Mar-10Apr-2026) board.
Ryasmeen edited projects, added: Verified; removed: Editing QA.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits