Page MenuHomePhabricator
Create Task
Maniphest T420398

Avoid using deprecated globals in ChannelFeed and related classes
Closed, ResolvedPublic
Actions

Description

ChannelFeed currently uses $wgOut and $wgRequest. The methods should take OutputPage/Request objects instead.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ChannelFeed: Remove hard-deprecated methodsmediawiki/coremaster+7 -93
ChannelFeed: Hard-deprecate outHeader(), outItem() and outFooter()mediawiki/coremaster+9 -5
AtomFeed: Use request from OutputPage instead of $wgRequestmediawiki/coremaster+6 -6
ChannelFeed: Pass request to contentType() instead of using $wgRequestmediawiki/coremaster+5 -8
ChannelFeed: Soft-deprecate outHeader(), outItem() and outFooter()mediawiki/coremaster+93 -25
ChannelFeed: Soft-deprecate httpHeaders() and outXmlHeader()mediawiki/coremaster+44 -12
ChannelFeed: Hard-deprecate httpHeaders() and outXmlHeader()mediawiki/coremaster+4 -1
Replace usage of deprecated ChannelFeed methodsmediawiki/extensions/FlaggedRevsmaster+5 -3
Replace usage of deprecated ChannelFeed methodsmediawiki/extensions/GoogleNewsSitemapmaster+10 -14
Replace usage of deprecated ChannelFeed::httpHeaders() methodmediawiki/extensions/GoogleNewsSitemapmaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

SomeRandomDeveloper created this task.Mar 17 2026, 5:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2026, 5:43 PM
gerritbot added a comment.Mar 17 2026, 7:14 PM

Change #1254296 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ChannelFeed: Soft-deprecate httpHeaders() and outXmlHeader()

https://gerrit.wikimedia.org/r/1254296

gerritbot added a project: Patch-For-Review.Mar 17 2026, 7:14 PM
gerritbot added a comment.Mar 17 2026, 7:18 PM

Change #1254297 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/GoogleNewsSitemap@master] Replace usage of deprecated ChannelFeed::httpHeaders() method

https://gerrit.wikimedia.org/r/1254297

gerritbot added a comment.Mar 17 2026, 7:22 PM

Change #1254298 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ChannelFeed: Hard-deprecate httpHeaders() and outXmlHeader()

https://gerrit.wikimedia.org/r/1254298

gerritbot added a comment.Mar 17 2026, 7:25 PM

Change #1254299 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ChannelFeed: Pass request to contentType() instead of using $wgRequest

https://gerrit.wikimedia.org/r/1254299

gerritbot added a comment.Mar 17 2026, 8:30 PM

Change #1254316 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ChannelFeed: Soft-deprecate outHeader(), outItem() and outFooter()

https://gerrit.wikimedia.org/r/1254316

gerritbot added a comment.Mar 17 2026, 8:40 PM

Change #1254318 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/GoogleNewsSitemap@master] Replace usage of deprecated ChannelFeed methods

https://gerrit.wikimedia.org/r/1254318

SomeRandomDeveloper added a project: MediaWiki-extensions-GoogleNewsSitemap.Mar 17 2026, 9:16 PM
gerritbot added a comment.Mar 17 2026, 9:22 PM

Change #1254296 merged by jenkins-bot:

[mediawiki/core@master] ChannelFeed: Soft-deprecate httpHeaders() and outXmlHeader()

https://gerrit.wikimedia.org/r/1254296

gerritbot added a comment.Mar 17 2026, 9:22 PM

Change #1254297 merged by jenkins-bot:

[mediawiki/extensions/GoogleNewsSitemap@master] Replace usage of deprecated ChannelFeed::httpHeaders() method

https://gerrit.wikimedia.org/r/1254297

gerritbot added a comment.Mar 17 2026, 9:25 PM

Change #1254298 merged by jenkins-bot:

[mediawiki/core@master] ChannelFeed: Hard-deprecate httpHeaders() and outXmlHeader()

https://gerrit.wikimedia.org/r/1254298

gerritbot added a comment.Mar 17 2026, 9:26 PM

Change #1254299 merged by jenkins-bot:

[mediawiki/core@master] ChannelFeed: Pass request to contentType() instead of using $wgRequest

https://gerrit.wikimedia.org/r/1254299

gerritbot added a comment.Mar 17 2026, 9:49 PM

Change #1254316 merged by jenkins-bot:

[mediawiki/core@master] ChannelFeed: Soft-deprecate outHeader(), outItem() and outFooter()

https://gerrit.wikimedia.org/r/1254316

gerritbot added a comment.Mar 17 2026, 9:49 PM

Change #1254318 merged by jenkins-bot:

[mediawiki/extensions/GoogleNewsSitemap@master] Replace usage of deprecated ChannelFeed methods

https://gerrit.wikimedia.org/r/1254318

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Mar 17 2026, 10:01 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2026, 10:31 PM
gerritbot added a comment.Mar 17 2026, 10:32 PM

Change #1254351 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/FlaggedRevs@master] Replace usage of deprecated ChannelFeed methods

https://gerrit.wikimedia.org/r/1254351

gerritbot added a project: Patch-For-Review.Mar 17 2026, 10:32 PM
gerritbot added a comment.Mar 17 2026, 10:47 PM

Change #1254357 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ChannelFeed: Hard-deprecate outHeader(), outItem() and outFooter()

https://gerrit.wikimedia.org/r/1254357

gerritbot added a comment.Mar 17 2026, 11:04 PM

Change #1254351 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace usage of deprecated ChannelFeed methods

https://gerrit.wikimedia.org/r/1254351

SomeRandomDeveloper added a project: FlaggedRevs.Mar 17 2026, 11:04 PM
gerritbot added a comment.Mar 17 2026, 11:35 PM

Change #1254363 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] AtomFeed: Use request from OutputPage instead of $wgRequest

https://gerrit.wikimedia.org/r/1254363

gerritbot added a comment.Mar 18 2026, 4:40 PM

Change #1254363 merged by jenkins-bot:

[mediawiki/core@master] AtomFeed: Use request from OutputPage instead of $wgRequest

https://gerrit.wikimedia.org/r/1254363

MGChecker subscribed.Mar 18 2026, 6:19 PM
Bugreporter2 awarded a token.Mar 23 2026, 11:56 PM
Bugreporter2 moved this task from Unsorted to Needs refactor on the Technical-Debt board.Mar 25 2026, 5:51 AM
gerritbot added a comment.Apr 15 2026, 12:56 AM

Change #1254357 merged by jenkins-bot:

[mediawiki/core@master] ChannelFeed: Hard-deprecate outHeader(), outItem() and outFooter()

https://gerrit.wikimedia.org/r/1254357

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28); removed: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24).Apr 15 2026, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 15 2026, 1:31 AM
gerritbot added a comment.May 1 2026, 7:46 PM

Change #1281610 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/core@master] ChannelFeed: Remove hard-deprecated methods

https://gerrit.wikimedia.org/r/1281610

gerritbot added a project: Patch-For-Review.May 1 2026, 7:46 PM
gerritbot added a comment.May 2 2026, 12:31 AM

Change #1281610 merged by jenkins-bot:

[mediawiki/core@master] ChannelFeed: Remove hard-deprecated methods

https://gerrit.wikimedia.org/r/1281610

SomeRandomDeveloper closed this task as Resolved.May 2 2026, 12:33 AM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 2 2026, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 2 2026, 1:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits