Page MenuHomePhabricator

Edit warning labels are confusing: "dismiss" and "continue"
Open, Needs TriagePublic

Description

For example this warning shown when I edit from my staff account:

image.png (542×388 px, 74 KB)

"Continue" is fairly clear, but "Dismiss" is very confusing, as usually dismiss means ignore the warning and continue. It should be "back" or "cancel".

Event Timeline

Change #1251077 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] Change "Dismiss" to "Back" when showing ProcessDialog errors.

https://gerrit.wikimedia.org/r/1251077

I agree that "Dismiss" seems wrong here. Is this a multi step dialog? If not, I'd lean towards calling it "Cancel" over "Back".

I agree that "Dismiss" seems wrong here. Is this a multi step dialog? If not, I'd lean towards calling it "Cancel" over "Back".

It's the abuse filter warning shown after clicking "publish changes" (if the edit triggers an abuse filter). "Continue" = publish the edit anyway , "Dismiss" = back to editing the page (e.g. in order to change the content that triggered the filter before trying to publish again). "Cancel" would probably be misleading because the button isn't canceling the edit...

Generically it's an overlay within the ProcessDialog. I think "back" is fine as within the ProcessDialog it will take you back to the previous screen you were on.

Change #1251077 merged by jenkins-bot:

[oojs/ui@master] Change "Dismiss" to "Back" when showing ProcessDialog errors.

https://gerrit.wikimedia.org/r/1251077

Change #1275892 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Upgrade OOUI from v0.53.1 to v0.53.2

https://gerrit.wikimedia.org/r/1275892

Change #1275892 merged by jenkins-bot:

[mediawiki/core@master] Upgrade OOUI from v0.53.1 to v0.53.2

https://gerrit.wikimedia.org/r/1275892