Page MenuHomePhabricator
Create Task
Maniphest T419666

WikiLambda: Replace direct usage of BagOStuff with WANObjectCache
Closed, ResolvedPublic
Actions

Description

Description

WikiLambdaZObjectStash is an instance of BagOStuff, used in all WikiLambda instances (repo, abstract and client instances), to store:

  • ZObjects: with key WikiLambdaObjectStorage:ZID
  • Results of embedded wikifunctions calls in client wikis: with key WikiLambdaClientFunctionCall:{"target"...
  • Results of function calls returned by the orchestrator to repo: with key WikiLambdaFunctionCall:Z7,Z7K1|Z27868,...
  • Results of abstract fragment render requests from abstract wiki: with key WikiLambdaAbstractFragment:qid|Q319,lang|Z1002,fragment|Z1K1|Z7,Z7K1

WANObjectCache was built to support the multi-DC initiative as a layer of constraints and best-practices in a multi-DC context.
Wikifunctions dedicated cache initially as local-DC no-replication configuration, and BagOStuff was sufficient.

For an improved cache architecture at Wikifunctions and for better traceability, we now require to remove direct use of BagOStuff and use the WANObjectCache wrapper.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mw-mcrouter: add /{dc}/wf-wan routes for Wikifunctions client cacheoperations/deployment-chartsmaster+30 -0
Wikifunctions: Switch cache from mcrouter-wikifunctions to special accessoperations/mediawiki-configmaster+15 -8
Replace WANObjectCache with new MemcachedWrapper conceptmediawiki/extensions/WikiLambdawmf/1.46.0-wmf.21+393 -177
Replace WANObjectCache with new MemcachedWrapper conceptmediawiki/extensions/WikiLambdamaster+393 -177
Replace direct BagOStuff with WANObjectCachemediawiki/extensions/WikiLambdawmf/1.46.0-wmf.19+43 -381
Replace direct BagOStuff with WANObjectCachemediawiki/extensions/WikiLambdamaster+103 -104
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Mar 11 2026, 9:04 AM
gengh claimed this task.Mar 11 2026, 9:22 AM
gengh updated the task description. (Show Details)
gerritbot added a comment.Mar 11 2026, 1:11 PM

Change #1250574 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Replace direct BagOStuff with WANObjectCache

https://gerrit.wikimedia.org/r/1250574

gerritbot added a project: Patch-For-Review.Mar 11 2026, 1:11 PM
Jdforrester-WMF triaged this task as High priority.Mar 11 2026, 1:27 PM
Jdforrester-WMF added a parent task: T411807: WF memcached service is dc-local but used for dc-global content.
Jdforrester-WMF edited projects, added: Essential-Work, Abstract Wikipedia team (26Q3 (Jan–Mar)); removed: Abstract Wikipedia team.
Jdforrester-WMF changed the task status from Open to In Progress.Mar 11 2026, 1:29 PM
Jdforrester-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
gerritbot added a comment.Mar 13 2026, 5:15 PM

Change #1250574 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Replace direct BagOStuff with WANObjectCache

https://gerrit.wikimedia.org/r/1250574

gerritbot added a comment.Mar 13 2026, 5:16 PM

Change #1251487 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.46.0-wmf.19] Replace direct BagOStuff with WANObjectCache

https://gerrit.wikimedia.org/r/1251487

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Mar 13 2026, 5:20 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 13 2026, 6:00 PM
gerritbot added a comment.Mar 16 2026, 1:02 PM

Change #1251487 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.46.0-wmf.19] Replace direct BagOStuff with WANObjectCache

https://gerrit.wikimedia.org/r/1251487

Stashbot added a comment.Mar 16 2026, 1:03 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-16T13:02:59Z] <jforrester@deploy2002> Started scap sync-world: Backport for [[gerrit:1251487|Replace direct BagOStuff with WANObjectCache (T419666)]]

Stashbot added a comment.Mar 16 2026, 1:06 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-16T13:06:54Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:1251487|Replace direct BagOStuff with WANObjectCache (T419666)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Mar 16 2026, 1:07 PM
Jdforrester-WMF subscribed.

Back-ported. Caches are still split between eqiad and codfw, but we're now using the proper system.

Stashbot added a comment.Mar 16 2026, 1:14 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-16T13:14:24Z] <jforrester@deploy2002> Finished scap sync-world: Backport for [[gerrit:1251487|Replace direct BagOStuff with WANObjectCache (T419666)]] (duration: 11m 25s)

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2026, 1:32 PM
ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10); removed: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 16 2026, 2:00 PM
gerritbot added a comment.Mar 20 2026, 4:21 PM

Change #1256431 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Revert "Replace direct BagOStuff with WANObjectCache"

https://gerrit.wikimedia.org/r/1256431

gerritbot added a project: Patch-For-Review.Mar 20 2026, 4:21 PM
gerritbot added a comment.Mar 20 2026, 4:23 PM

Change #1256432 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] Wikifunctions: Switch cache from mcrouter-wikifunctions to basic

https://gerrit.wikimedia.org/r/1256432

gengh added a comment.Mar 23 2026, 10:27 AM

Tried this. Closing, although it wasn't the right approach and we will be following a different path going forward.

gengh closed this task as Resolved.Mar 23 2026, 10:27 AM
gerritbot added a comment.Mar 25 2026, 2:31 PM

Change #1256431 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Replace WANObjectCache with new MemcachedWrapper concept

https://gerrit.wikimedia.org/r/1256431

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31); removed: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 25 2026, 3:00 PM
gerritbot added a comment.Mar 26 2026, 3:10 PM

Change #1261477 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@wmf/1.46.0-wmf.21] Replace WANObjectCache with new MemcachedWrapper concept

https://gerrit.wikimedia.org/r/1261477

gerritbot added a comment.Mar 30 2026, 1:30 PM

Change #1261477 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.46.0-wmf.21] Replace WANObjectCache with new MemcachedWrapper concept

https://gerrit.wikimedia.org/r/1261477

Maintenance_bot added a project: Abstract Wikipedia.Mar 30 2026, 1:30 PM
Stashbot mentioned this in T419181: Update and Restart Revise Tone Experiment.Mar 30 2026, 1:30 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-30T13:30:50Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1264590|instrument(ReviseTone): record start of copyedit session (T419181)]], [[gerrit:1261477|Replace WANObjectCache with new MemcachedWrapper concept (T419666)]], [[gerrit:1262199|Fix match case for setting minute, week or month TTL on OrchestratorRequest (T421475)]]

Stashbot mentioned this in T421475: OrchestratorRequest: fails setting ttl with UnhandledMatchError.Mar 30 2026, 1:30 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-30T13:32:33Z] <jforrester@deploy1003> jforrester, migr: Backport for [[gerrit:1264590|instrument(ReviseTone): record start of copyedit session (T419181)]], [[gerrit:1261477|Replace WANObjectCache with new MemcachedWrapper concept (T419666)]], [[gerrit:1262199|Fix match case for setting minute, week or month TTL on OrchestratorRequest (T421475)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can

Stashbot added a comment.Mar 30 2026, 1:40 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-30T13:40:24Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1264590|instrument(ReviseTone): record start of copyedit session (T419181)]], [[gerrit:1261477|Replace WANObjectCache with new MemcachedWrapper concept (T419666)]], [[gerrit:1262199|Fix match case for setting minute, week or month TTL on OrchestratorRequest (T421475)]] (duration: 09m 33s)

gerritbot added a comment.Mar 30 2026, 1:41 PM

Change #1256432 merged by jenkins-bot:

[operations/mediawiki-config@master] Wikifunctions: Switch cache from mcrouter-wikifunctions to special access

https://gerrit.wikimedia.org/r/1256432

Stashbot added a comment.Mar 30 2026, 1:42 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-30T13:42:02Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1256432|Wikifunctions: Switch cache from mcrouter-wikifunctions to special access (T419666)]]

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2026, 1:43 PM
Stashbot added a comment.Mar 30 2026, 1:43 PM

Mentioned in SAL (#wikimedia-operations) [2026-03-30T13:43:45Z] <jforrester@deploy1003> jforrester: Backport for [[gerrit:1256432|Wikifunctions: Switch cache from mcrouter-wikifunctions to special access (T419666)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.21; 2026-03-24); removed: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 30 2026, 2:00 PM
gerritbot added a comment.Apr 8 2026, 6:33 PM

Change #1269038 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] mw-mcrouter: add /{dc}/wf-wan routes for Wikifunctions client cache

https://gerrit.wikimedia.org/r/1269038

gerritbot added a project: Patch-For-Review.Apr 8 2026, 6:33 PM
gerritbot added a comment.Apr 8 2026, 6:52 PM

Change #1269038 merged by jenkins-bot:

[operations/deployment-charts@master] mw-mcrouter: add /{dc}/wf-wan routes for Wikifunctions client cache

https://gerrit.wikimedia.org/r/1269038

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2026, 7:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits