Background
Following T409098: Remove VectorNightMode feature flag from Vector which removed the night mode feature flag in Vector, we need to do the same in Minerva
User story
As a reader, I'd like to have old temporary feature classes to not be persisting in the HTML, and for the developers to be able to maintain the site so that new features can be more quickly built
Requirements
- Feature flag $wgMinervaNightMode is removed from Minerva https://codesearch.wmcloud.org/search/?q=%28wgMinervaNightMode%7CMinervaNightModeOptions%29&files=&excludeFiles=&repos=
- Feature flag $wgMinervaNightModeOptions is removed from Minerva
- Documentation is updated
BDD
Note: all the test scenraios are for regression testing, i.e. assessing the UX is un-changed by removing temp flags.
Scenario 1 enabling Dark mode in Minerva (mobile) for non-logged/logged users
Given a non-logged/logged-in user is on mobile
When a user enables Dark mode in settings
Then the dark mode is present and functions as before
Scenario 2 enabling Dark mode for Minerva on desktop
Given a non-logged/logged-in user is on Desktop and enables Minerva skin
When a user enables Dark mode in settings
Then the dark mode is present and functions as before
Scenario 3 quick check on other skins on mobile for logged-in users
Given a logged-in user is on mobile
When a user enables different skins
And a user enables a Dark mode for Minerva skin
Then a user experience is unchanged
Scenario 4 confirm query string parameter
Given a logged out user is on mobile
When a user visits https://en.wikipedia.beta.wmcloud.org/wiki/Main_Page?minervanightmode=1 OR https://en.wikipedia.beta.wmcloud.org/wiki/Main_Page?minervanightmode=0
Then user experience should reflect the URL
Test Steps
- check the scenarios above in Chrome, FF, and Safari on mobile (iOS and Android) and with Minerva skin enabled on desktop
- check Dark mode for a user in incognito window
Design
- Add mockups and design requirements
Acceptance criteria
- Add acceptance criteria
Communication criteria - does this need an announcement or discussion?
- Add communication criteria
Rollback plan
- What is the rollback plan in production for this task if something goes wrong?
This task was created by Version 1.2.0 of the Web team task template using phabulous