Make the stop button more prominent by adding colour to it. Adding the destructive flag would make it a different colour from the play button. It also makes sense semantically stopping the playback means you loose your place in the text.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Upgrade OOUI from v0.53.1 to v0.53.2 | mediawiki/core | master | +494 -103 | |
| Add destructive variant for stop icon | oojs/ui | master | +2 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T405326 ☂ Improve playback icons | |||
| Open | None | T414410 Add colour to the stop button |
Event Timeline
Comment Actions
When we discussed this earlier (in T405326) we came to the conclusion that two primary buttons next to each other didn't look great. Therefore the stop button shouldn't be primary, making just the symbol red.
Comment Actions
Change #1194133 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):
[oojs/ui@master] Add destructive variant for stop icon
Comment Actions
Change #1194133 merged by jenkins-bot:
[oojs/ui@master] Add destructive variant for stop icon
Comment Actions
I merged the patch as I can see a case where stop might be destructive (e.g. in a progress bar), but some concerns were raised on the task:
Volker E.
Just don't think this is the right UX approach. It's misleading users by overemphasizing one element that should be equal to others even though I understand some of the sentiment behind. Sorry, taking myself off this patch.
I agree that it's a bit of a stretch to say that losing your playback position is "destructive", and this isn't a pattern I've seen anywhere else in media players.
Comment Actions
Change #1275892 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/core@master] Upgrade OOUI from v0.53.1 to v0.53.2
Comment Actions
Change #1275892 merged by jenkins-bot:
[mediawiki/core@master] Upgrade OOUI from v0.53.1 to v0.53.2
Comment Actions
Thank you for merging and the feedback. I can understand that the playback may not be as severe as other "destructive" actions. It was however a request from a test with a user group that the stop button should be emphasised.
At least now we can try if it's a good fit without having to resort to a hack solution 🙂