Page MenuHomePhabricator

Wikibase has a flaky cypress test in addQualifier.cy.ts
Open, HighPublic

Description

Flaky cypress test
https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-selenium-php83/4148/console

18:10:38   1) wbui2025 add qualifiers
18:10:38        mobile view
18:10:38          is possible to add and edit a qualifier:
18:10:38      CypressError: Timed out retrying after 1000ms: `cy.click()` failed because this element is `disabled`:
18:10:38 
18:10:38 `<button class="cdx-button cdx-button--action-progressive cdx-button--weight-primary cdx-button--size-medium cdx-button--framed" disabled="">...</button>`
18:10:38 
18:10:38 Fix this problem, or use `{force: true}` to disable error checking.
18:10:38 
18:10:38 https://on.cypress.io/element-cannot-be-interacted-with
18:10:38       at Object.isNotDisabled (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:148344:58)
18:10:38       at runAllChecks (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:114722:26)
18:10:38       at retryActionability (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:114811:16)
18:10:38       at tryCatcher (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:1777:23)
18:10:38       at Promise.attempt.Promise.try (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:4285:29)
18:10:38       at whenStable (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:147205:68)
18:10:38       at <unknown> (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:147146:14)
18:10:38       at tryCatcher (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:1777:23)
18:10:38       at Promise._settlePromiseFromHandler (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:1489:31)
18:10:38       at Promise._settlePromise (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:1546:18)
18:10:38       at Promise._settlePromise0 (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:1591:10)
18:10:38       at Promise._settlePromises (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:1671:18)
18:10:38       at Promise._fulfill (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:1615:18)
18:10:38       at <unknown> (http://127.0.0.1:9413/__cypress/runner/cypress_runner.js:5420:46)

See also: T418778: Flaky Cypress test: wbui2025 add qualifiers: mobile view (wbui2025) - tabular-data qualifier: can add a tabular-data qualifier with lookup:

Acceptance Criteria

  • The error no longer occurs

Event Timeline

Reedy triaged this task as High priority.Fri, May 15, 3:30 PM

Change #1287953 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Wikibase@master] Cypress tests: Skip addQualifier > mobile view > is possible to add and edit a qualifier, flaky

https://gerrit.wikimedia.org/r/1287953

Judging by the screenshot, I think this was actually still waiting for the wbparsevalue request to return? Maybe we need to increase the timeout for this button click? (Edit: or separately wait for the network request first?)

(See also the video; the error happens ca. 18 seconds in.)

Change #1290787 had a related patch set uploaded (by Mahmoud-abdelsattar; author: Mahmoud-abdelsattar):

[mediawiki/extensions/Wikibase@master] Flaky test addQualifier theory testing

https://gerrit.wikimedia.org/r/1290787

Change #1287953 merged by Reedy:

[mediawiki/extensions/Wikibase@master] Cypress tests: Skip addQualifier > mobile view > is possible to add and edit a qualifier, flaky

https://gerrit.wikimedia.org/r/1287953

Change #1291984 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Revert "Cypress tests: Skip addQualifier > mobile view > is possible to add and edit a qualifier, flaky"

https://gerrit.wikimedia.org/r/1291984

Change #1291984 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] Revert "Cypress tests: Skip addQualifier > mobile view > is possible to add and edit a qualifier, flaky"

Reason:

superseded by Id1bef90fd5

https://gerrit.wikimedia.org/r/1291984

Change #1290787 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Flaky test addQualifier timeout issue

https://gerrit.wikimedia.org/r/1290787

Let’s see if this particular flaky error still happens over the next days, I guess…

I'll pause the moving forward of this task for now so we can observe the Flaky test behavior.