Page MenuHomePhabricator

OAuth authorization dialog should preserve common query parameters when redirecting to login
Closed, ResolvedPublic

Description

uselang etc. should be passed on and applied to the login flow. This means OAuth 2 internal redirects also need to preserve them.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1286987 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] auth: Preserve user language in UserNotLoggedIn

https://gerrit.wikimedia.org/r/1286987

Change #1288019 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/OAuth@master] rest: Support some OIDC parameters in oauth2/authorize

https://gerrit.wikimedia.org/r/1288019

Change #1286987 merged by jenkins-bot:

[mediawiki/core@master] auth: Preserve user language in UserNotLoggedIn

https://gerrit.wikimedia.org/r/1286987

Change #1288019 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] rest: Support some OIDC parameters in oauth2/authorize

https://gerrit.wikimedia.org/r/1288019

In CentralAuth SUL2 mode, display=popup gets lost during signup because it's not preserved during central login. Given that CentralAuth is very Wikimedia-specific, Wikimedia does not use SUL2 mode, central login is not used in SUL3 except for temp user creation, and temp user creation can't happen during OAuth flows, I'm not inclined to fix that.