Page MenuHomePhabricator

OATHAuth's PHPUnit test coverage needs improving
Open, MediumPublic

Description

https://doc.wikimedia.org/cover-extensions/OATHAuth/

src/:

  • 2026-06-10 - 51.84% of lines (1827 / 3524)
  • 2026-06-03 - 50.99% of lines (1795 / 3520)
  • 2026-06-02 - 50.73% of lines (1775 / 3499)
  • 2026-06-01 - 50.77% of lines (1779 / 3504)
  • 2026-05-28 - 50.07% of lines (1756 / 3507)
  • 2026-05-27 - 49.30% of lines (1727 / 3503)
  • 2026-05-26 - 49.66% of lines (1699 / 3421)
  • 2026-05-06 - 50.21% of lines (1708 / 3402)
  • 2026-04-29 - 50.00% of lines (1695 / 3390)
  • 2026-04-27 - 49.36% of lines (1693 / 3430)
  • 2026-04-24 - 48.73% of lines (1691 / 3470)
  • 2026-04-08 - 47.74% of lines (1583 / 3316)
  • 2026-03-25 - 47.79% of lines (1579 / 3304)
  • 2026-03-24 - 48.36% of lines (1625 / 3360)
  • 2026-03-23 - 47.14% of lines (1584 / 3360)
  • 2026-03-22 - 46.02% of lines (1550 / 3368)
  • 2026-03-09 - 46.12% of lines (1502 / 3257)
  • 2026-02-13 - 43.96% of lines (1307 / 2973)
  • 2026-02-08 - 43.61% of lines
  • 2026-02-05 - 41.31% of lines
  • 2026-01-29 - 40.12% of lines (after WebAuthn was merged in)
  • 2026-01-02 - 54.10% of lines
  • 2025-12-03 - 51.14% of lines
  • 2025-11-10 - 39.73% of lines
  • 2025-11-06 - 37.63% of lines
  • 2025-09-17 - 19.87% of lines

maintenance/:

  • 2026-06-03 - 81.58% of lines (372 / 456)
  • 2026-06-02 - 88.78% of lines (364 / 410)
  • 2026-06-01 - 86.84% of lines (363 / 418)
  • 2026-05-29 - 68.18% of lines (285 / 418)
  • 2026-05-26 - 22.43% of lines (107 / 477)
  • 2026-05-26 - 5.25% of lines (16 / 378)
  • 2026-05-06 - 5.25% of lines (16 / 305)
  • 2026-04-24 - 5.59% of lines (16 / 286)
  • 2026-03-23 - 6.27% of lines (16 / 255)
  • 2026-03-20 - 5.49% of lines (14 / 255)
  • 2026-03-19 - 0.00% of lines (0 / 255)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
mediawiki/extensions/OATHAuthmaster+9 -1
mediawiki/extensions/OATHAuthmaster+46 -15
mediawiki/extensions/OATHAuthmaster+26 -1
mediawiki/extensions/OATHAuthmaster+28 -1
mediawiki/extensions/OATHAuthmaster+63 -0
mediawiki/extensions/OATHAuthmaster+22 -0
mediawiki/extensions/OATHAuthmaster+35 -0
mediawiki/extensions/OATHAuthmaster+23 -0
mediawiki/extensions/OATHAuthmaster+9 -0
mediawiki/extensions/OATHAuthmaster+26 -0
mediawiki/extensions/OATHAuthmaster+26 -0
mediawiki/extensions/OATHAuthmaster+29 -0
mediawiki/extensions/OATHAuthmaster+23 -0
mediawiki/extensions/OATHAuthmaster+25 -0
mediawiki/extensions/OATHAuthmaster+119 -39
mediawiki/extensions/OATHAuthmaster+138 -0
mediawiki/extensions/OATHAuthmaster+3 -0
mediawiki/extensions/OATHAuthmaster+13 -0
mediawiki/extensions/OATHAuthmaster+2 -1
mediawiki/extensions/OATHAuthmaster+1 -0
mediawiki/extensions/OATHAuthmaster+6 -0
mediawiki/extensions/OATHAuthmaster+6 -0
mediawiki/extensions/OATHAuthmaster+2 -0
mediawiki/extensions/OATHAuthmaster+30 -0
mediawiki/extensions/OATHAuthmaster+20 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1256621 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add some more covers for OATHAuthServices

https://gerrit.wikimedia.org/r/1256621

Change #1256622 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Add @covers for AuthKey

https://gerrit.wikimedia.org/r/1256622

Change #1256623 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] TOTPKey: Add some @codeCoverageIgnore

https://gerrit.wikimedia.org/r/1256623

Change #1256624 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test jsonSerialize()

https://gerrit.wikimedia.org/r/1256624

Change #1256626 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test setPasswordlessSupport()

https://gerrit.wikimedia.org/r/1256626

Change #1258351 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] DisableOATHAuthForUserTest: Go for 100% test coverage

https://gerrit.wikimedia.org/r/1258351

Change #1258351 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] DisableOATHAuthForUserTest: Go for 100% test coverage

https://gerrit.wikimedia.org/r/1258351

Change #1256610 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] OATHAuthModuleRegistryTest: Add more tests to increase coverage

https://gerrit.wikimedia.org/r/1256610

Change #1256613 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] OATHAuthLogger: Add @codeCoverageIgnore when CheckUser not loaded

https://gerrit.wikimedia.org/r/1256613

Change #1256621 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add some more covers for OATHAuthServices

https://gerrit.wikimedia.org/r/1256621

Change #1256622 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Add @covers for AuthKey

https://gerrit.wikimedia.org/r/1256622

Change #1256623 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] TOTPKey: Add some @codeCoverageIgnore

https://gerrit.wikimedia.org/r/1256623

Change #1256624 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test jsonSerialize()

https://gerrit.wikimedia.org/r/1256624

Change #1256626 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test setPasswordlessSupport()

https://gerrit.wikimedia.org/r/1256626

Change #1259223 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Mark some tests as covering OATHUser

https://gerrit.wikimedia.org/r/1259223

Change #1259223 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Mark some tests as covering OATHUser

https://gerrit.wikimedia.org/r/1259223

Reedy triaged this task as Medium priority.May 6 2026, 1:47 PM

Change #1256555 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add test for ReEncryptSecrets maintenance script

https://gerrit.wikimedia.org/r/1256555

Change #1294350 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add coverage for UpdateSecretsToEncryptedFormat

https://gerrit.wikimedia.org/r/1294350

Change #1294350 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add coverage for UpdateSecretsToEncryptedFormat

https://gerrit.wikimedia.org/r/1294350

Change #1294381 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for Recover2FAForUser

https://gerrit.wikimedia.org/r/1294381

Change #1294380 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for NotifyTwoFactorRequired

https://gerrit.wikimedia.org/r/1294380

Change #1294382 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for PurgeExpiredTemporaryRecoveryCodes

https://gerrit.wikimedia.org/r/1294382

Change #1294381 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for Recover2FAForUser

https://gerrit.wikimedia.org/r/1294381

Change #1294382 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for PurgeExpiredTemporaryRecoveryCodes

https://gerrit.wikimedia.org/r/1294382

Change #1294994 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for PopulateUserHandles

https://gerrit.wikimedia.org/r/1294994

Change #1295000 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for MoveRecoveryCodesFromTOTP

https://gerrit.wikimedia.org/r/1295000

Change #1295000 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for MoveRecoveryCodesFromTOTP

https://gerrit.wikimedia.org/r/1295000

Change #1294380 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for NotifyTwoFactorRequired

https://gerrit.wikimedia.org/r/1294380

Change #1294994 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add basic test for PopulateUserHandles

https://gerrit.wikimedia.org/r/1294994

Reedy renamed this task from OATHAuth has low PHPUnit test coverage to OATHAuth's PHPUnit test coverage needs improving.Thu, May 28, 2:19 PM
Reedy updated the task description. (Show Details)

Change #1295025 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add another test case for NotifyTwoFactorRequired

https://gerrit.wikimedia.org/r/1295025

Change #1295026 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add another test case for PurgeExpiredTemporaryRecoveryCodes

https://gerrit.wikimedia.org/r/1295026

Change #1295027 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add another test case for PopulateUserHandles

https://gerrit.wikimedia.org/r/1295027

Change #1295026 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add another test case for PurgeExpiredTemporaryRecoveryCodes

https://gerrit.wikimedia.org/r/1295026

Change #1295027 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add another test case for PopulateUserHandles

https://gerrit.wikimedia.org/r/1295027

Change #1295025 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add another test case for NotifyTwoFactorRequired

https://gerrit.wikimedia.org/r/1295025

Change #1295977 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] MoveRecoveryCodesFromTOTPTest: Add a test actually moving the recovery codes

https://gerrit.wikimedia.org/r/1295977

Change #1295989 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] PurgeExpiredTemporaryRecoveryCodesTest: Add a test removing an expired recovery code

https://gerrit.wikimedia.org/r/1295989

Change #1295989 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] PurgeExpiredTemporaryRecoveryCodesTest: Add a test removing an expired recovery code

https://gerrit.wikimedia.org/r/1295989

Change #1295977 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] MoveRecoveryCodesFromTOTPTest: Add a test actually moving the recovery codes

https://gerrit.wikimedia.org/r/1295977

Change #1296034 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] Recover2FAForUserTest: Add coverage for email sent

https://gerrit.wikimedia.org/r/1296034

Change #1296034 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Recover2FAForUserTest: Add coverage for email sent

https://gerrit.wikimedia.org/r/1296034

Change #1296708 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] Add test and description for UpdateKeysToLatestVersion

https://gerrit.wikimedia.org/r/1296708

Change #1296708 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Add test and description for UpdateKeysToLatestVersion

https://gerrit.wikimedia.org/r/1296708

Change #1297707 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Increase test coverage for ExpiringRecoveryCodeGenerator

https://gerrit.wikimedia.org/r/1297707

Change #1297707 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Increase test coverage for ExpiringRecoveryCodeGenerator

https://gerrit.wikimedia.org/r/1297707

Change #1300936 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] Few more @covers and @codeCoverageIgnore

https://gerrit.wikimedia.org/r/1300936