Page MenuHomePhabricator
Create Task
Maniphest T400800

Refactor Cite to use resource loader package files
Closed, ResolvedPublic
Actions

Description

In order to use even the CSS-only version of codex icons, we need to use ResourceLoader package files to load the icons.

This is a minor rewrite which we've done many times in the past. The steps are:

  • Create an "init" JS module for each RL module, list that as the first item in packageFiles.
  • Export any public API in that init module.
  • Protect the global namespace.
  • Don't write to global mw variables.
  • Refactor usages of each RL module.

Random example migration

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

MareikeHeuerWMDE created this task.Jul 30 2025, 10:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2025, 10:55 AM
awight added a parent task: T399196: Remove numbering from add/edit details dialog .Jul 30 2025, 11:14 AM
awight updated the task description. (Show Details)Jul 30 2025, 11:26 AM
awight updated the task description. (Show Details)Jul 30 2025, 11:32 AM
Izno added a project: Cite.Jul 30 2025, 2:29 PM
MareikeHeuerWMDE claimed this task.Jul 31 2025, 7:13 AM
MareikeHeuerWMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-07-23-Cherry-Chocolate-Ice-Cream board.
MareikeHeuerWMDE removed MareikeHeuerWMDE as the assignee of this task.Aug 1 2025, 10:01 AM
MareikeHeuerWMDE moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2025-07-23-Cherry-Chocolate-Ice-Cream board.
thiemowmde claimed this task.Aug 5 2025, 2:41 PM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-07-23-Cherry-Chocolate-Ice-Cream board.
thiemowmde added a project: WMDE-TechWish-Sprint-2025-08-06-Kekstazie-Icecream.Aug 6 2025, 8:36 AM
thiemowmde moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-08-06-Kekstazie-Icecream board.
gerritbot added a comment.Aug 6 2025, 12:05 PM

Change #1176214 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Merge unused ext.cite.visualEditor.core ResourceModule away

https://gerrit.wikimedia.org/r/1176214

gerritbot added a project: Patch-For-Review.Aug 6 2025, 12:05 PM
Krinkle awarded a token.Aug 6 2025, 12:23 PM
gerritbot added a comment.Aug 6 2025, 5:11 PM

Change #1176287 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [WIP] Use ResourceLoader packageFiles instead of scripts

https://gerrit.wikimedia.org/r/1176287

gerritbot added a comment.Aug 7 2025, 5:49 AM

Change #1176349 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Split multi-class file MWReferenceDialogTool

https://gerrit.wikimedia.org/r/1176349

gerritbot added a comment.Aug 7 2025, 7:51 AM

Change #1176214 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Merge unused ext.cite.visualEditor.core ResourceModule away

https://gerrit.wikimedia.org/r/1176214

gerritbot added a comment.Aug 7 2025, 7:51 AM

Change #1176349 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Split multi-class file MWReferenceDialogTool

https://gerrit.wikimedia.org/r/1176349

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 7 2025, 8:00 AM
gerritbot added a comment.Aug 11 2025, 9:50 AM

Change #1177332 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Turn virtual .js files into .json resources

https://gerrit.wikimedia.org/r/1177332

gerritbot added a comment.Aug 11 2025, 6:57 PM

Change #1177466 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove extra function closures from all .js files

https://gerrit.wikimedia.org/r/1177466

gerritbot added a comment.Aug 11 2025, 7:17 PM

Change #1177473 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move all registration calls into the new init.js file

https://gerrit.wikimedia.org/r/1177473

thiemowmde moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2025-08-06-Kekstazie-Icecream board.Aug 13 2025, 6:33 AM
gerritbot added a comment.Aug 13 2025, 7:02 AM

Change #1178401 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/ContentTranslation@master] Fix CX messing with private implementation details of Cite

https://gerrit.wikimedia.org/r/1178401

gerritbot added a comment.Aug 13 2025, 7:10 AM

Change #1176287 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use ResourceLoader packageFiles instead of scripts

https://gerrit.wikimedia.org/r/1176287

gerritbot added a comment.Aug 13 2025, 7:14 AM

Change #1178405 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Citoid@master] Update Citoid to use Cite packageFiles registration

https://gerrit.wikimedia.org/r/1178405

gerritbot added a comment.Aug 13 2025, 7:48 AM

Change #1177332 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Turn virtual .js files into .json resources

https://gerrit.wikimedia.org/r/1177332

gerritbot added a comment.Aug 13 2025, 7:50 AM

Change #1177466 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove a few not needed function closures from .js files

https://gerrit.wikimedia.org/r/1177466

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.15; 2025-08-19); removed: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 13 2025, 8:00 AM
gerritbot added a comment.Aug 13 2025, 1:44 PM

Change #1177473 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move all registration calls into the new init.js file

https://gerrit.wikimedia.org/r/1177473

gerritbot added a comment.Aug 15 2025, 8:31 AM

Change #1179102 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Citoid@master] Streamline fragile Cite tool unregistration

https://gerrit.wikimedia.org/r/1179102

gerritbot added a comment.Aug 15 2025, 9:20 AM

Change #1179106 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use existing CommandRegistry.getNames()

https://gerrit.wikimedia.org/r/1179106

gerritbot added a comment.Aug 18 2025, 11:10 AM

Change #1178401 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Update CX integration with Cite to be more stable

https://gerrit.wikimedia.org/r/1178401

gerritbot added a comment.Aug 19 2025, 8:39 AM

Change #1179102 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Streamline fragile Cite tool unregistration

https://gerrit.wikimedia.org/r/1179102

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26); removed: MW-1.45-notes (1.45.0-wmf.15; 2025-08-19).Aug 19 2025, 9:00 AM
Tobi_WMDE_SW mentioned this in T399196: Remove numbering from add/edit details dialog .Aug 19 2025, 11:25 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2025-08-20-Strawberry-Basil-Icecream.Aug 20 2025, 8:20 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2025-08-20-Strawberry-Basil-Icecream board.
Tobi_WMDE_SW mentioned this in WMDE-TechWish-Sprint-2025-08-20-Strawberry-Basil-Icecream.Aug 20 2025, 8:32 AM
gerritbot added a comment.Aug 21 2025, 10:58 AM

Change #1179106 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use existing CommandRegistry.getNames()

https://gerrit.wikimedia.org/r/1179106

WMDE-Fisch moved this task from Tech Review to Watching / Stalled on the WMDE-TechWish-Sprint-2025-08-20-Strawberry-Basil-Icecream board.Sep 1 2025, 5:38 PM
WMDE-Fisch subscribed.

Moving to watching because the last patch waits for Editing Team reviews and also - as I understand it - it's not a big blocker for our roadmap.

thiemowmde added a comment.Sep 2 2025, 7:56 AM

the last patch waits for Editing Team reviews

I'm not sure where this idea comes from. We can merge it. Even if another team has another idea about the use of factories the code can easily be changed in any direction.

WMDE-Fisch closed this task as Resolved.Sep 3 2025, 8:56 AM
gerritbot added a comment.Oct 10 2025, 11:26 AM

Change #1178405 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Update Citoid integration with Cite to be more stable

https://gerrit.wikimedia.org/r/1178405

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2025, 11:32 AM
ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14); removed: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Oct 10 2025, 12:00 PM
gerritbot added a comment.Mar 25 2026, 8:47 AM

Change #1260620 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [POC] Change QUnit tests to load packageFile via require

https://gerrit.wikimedia.org/r/1260620

gerritbot added a project: Patch-For-Review.Mar 25 2026, 8:47 AM
gerritbot added a comment.Mar 26 2026, 9:33 AM

Change #1261361 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use consistent "init.js" naming scheme for packageFiles

https://gerrit.wikimedia.org/r/1261361

gerritbot added a comment.Mar 26 2026, 11:14 AM

Change #1261361 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use consistent "init.js" naming scheme for packageFiles

https://gerrit.wikimedia.org/r/1261361

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 26 2026, 12:00 PM
gerritbot added a comment.Apr 10 2026, 10:32 AM

Change #1260620 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Change QUnit tests to load packageFile via require

https://gerrit.wikimedia.org/r/1260620

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Apr 10 2026, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 10 2026, 11:31 AM
gerritbot added a comment.Apr 13 2026, 2:58 PM

Change #1260642 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Change MWDataTransitionHelper for use with require

https://gerrit.wikimedia.org/r/1260642

gerritbot added a project: Patch-For-Review.Apr 13 2026, 2:58 PM
gerritbot added a comment.Apr 13 2026, 4:53 PM

Change #1260642 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Change MWDataTransitionHelper test to use require()

https://gerrit.wikimedia.org/r/1260642

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2026, 5:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits