Page MenuHomePhabricator

Upgrade monolog/monolog to 3.9.0 or later
Open, In Progress, MediumPublic

Description

reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/vendor$ php8.1 `which composer` depends monolog/monolog
__root__           dev-master requires monolog/monolog (2.9.3)
wikimedia/shellbox 4.3.0      requires monolog/monolog (^2.0.0)

Event Timeline

Change #1235415 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/Shellbox@master] composer.json: Re-allow monolog/monolog ^3.0.0

https://gerrit.wikimedia.org/r/1235415

Change #1235415 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] composer.json: Upgrade to monolog/monolog ^3.0.0

https://gerrit.wikimedia.org/r/1235415

Change #1286347 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/libs/Shellbox@master] Release v4.5.0

https://gerrit.wikimedia.org/r/1286347

Change #1286347 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] Release v4.5.0

https://gerrit.wikimedia.org/r/1286347

Change #1286350 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/libs/Shellbox@master] Expand monolog/monolog support to ^2.0.0 || ^3.0.0

https://gerrit.wikimedia.org/r/1286350

Change #1286351 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/libs/Shellbox@master] Release v4.5.1

https://gerrit.wikimedia.org/r/1286351

The signature of AbstractProcessingHandler::write changed in v3 (https://github.com/Seldaek/monolog/commit/22c8b19358e916c52f1d2170d44e172152de7c25#diff-374a6357e3f89f4b70f66a1606f8bd74c7e2bd39dce237578d134d86beb420c1)

The explicit type declaration needs to be removed, because the new LogRecord implements ArrayAccess and everything should still work?

Fatal error: Declaration of MediaWiki\Logger\Monolog\LegacyHandler::write(array $record): void must be compatible with Monolog\Handler\AbstractProcessingHandler::write(Monolog\LogRecord $record): void
Fatal error: Declaration of MediaWiki\Extension\EventBus\Adapters\Monolog\EventBusMonologHandler::write(array $record): void must be compatible with Monolog\Handler\AbstractProcessingHandler::write(Monolog\LogRecord $record): void
Fatal error: Declaration of MediaWikiLogHandler::write(array $record): void must be compatible with Monolog\Handler\AbstractProcessingHandler::write(Monolog\LogRecord $record): void

https://codesearch.wmcloud.org/search/?q=AbstractProcessingHandler

Change #1296010 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Forward compatibility change for AbstractProcessingHandler on monolog v3

https://gerrit.wikimedia.org/r/1296010

Change #1296011 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DonationInterface@master] Forward compatibility change for AbstractProcessingHandler on monolog v3

https://gerrit.wikimedia.org/r/1296011

Change #1296012 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/EventBus@master] Forward compatibility change for AbstractProcessingHandler on monolog v3

https://gerrit.wikimedia.org/r/1296012

Change #1296012 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Forward compatibility change for AbstractProcessingHandler on monolog v3

https://gerrit.wikimedia.org/r/1296012

Change #1296011 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Forward compatibility change for AbstractProcessingHandler on monolog v3

https://gerrit.wikimedia.org/r/1296011

Change #1296010 merged by jenkins-bot:

[mediawiki/core@master] Forward compatibility change for AbstractProcessingHandler on monolog v3

https://gerrit.wikimedia.org/r/1296010

Change #1297637 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Forward compatibility change for log formatter/buffer on monolog v3

https://gerrit.wikimedia.org/r/1297637

Change #1298410 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaEvents@master] Forward compatibility change for AuthManagerStatsdHandler on monolog v3

https://gerrit.wikimedia.org/r/1298410

Change #1298410 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Forward compatibility change for AuthManagerStatsdHandler on monolog v3

https://gerrit.wikimedia.org/r/1298410

Change #1297637 merged by jenkins-bot:

[mediawiki/core@master] Forward compatibility change for log formatter/buffer on monolog v3

https://gerrit.wikimedia.org/r/1297637

Change #1298872 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/vendor@master] Upgrade monolog/monolog from v2.11.0 to v3.10.0

https://gerrit.wikimedia.org/r/1298872

Change #1298873 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Upgrade monolog/monolog from v2.11.0 to v3.10.0

https://gerrit.wikimedia.org/r/1298873

Change #1298900 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] logger: Make LogstashFormatter::format() accept array or LogRecord

https://gerrit.wikimedia.org/r/1298900

Jdforrester-WMF changed the task status from Open to In Progress.Mon, Jun 8, 9:22 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF triaged this task as Medium priority.

Change #1298916 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] logger: Soft-deprecate passing arrays to Monolog handlers/formatters

https://gerrit.wikimedia.org/r/1298916

Change #1298917 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] logger: Replace deprecated Monolog\Logger level constants with Level enum

https://gerrit.wikimedia.org/r/1298917

Change #1298918 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] logger: Require LogRecord (not array) for Monolog handlers/formatters

https://gerrit.wikimedia.org/r/1298918

Change #1298900 merged by jenkins-bot:

[mediawiki/core@master] logger: Make LogstashFormatter::format() accept array or LogRecord

https://gerrit.wikimedia.org/r/1298900