Page MenuHomePhabricator

Display secondary edit details button in ContextItem for sub-refs
Closed, ResolvedPublic

Description

GIVEN I have a document with subrefs
WHEN I click on a subref footnote marker
THEN I see the context Item with two edit buttons, one for the main and one for the detail

image.png (776×516 px, 49 KB)

The top edit button will now edit the main ref, and the bottom edit button will edit the subref. In order to edit the main ref, the callback probably needs to select the main ref footnote body in the same way as if the user had clicked in the reference list to edit it there. We can't assume the main ref has its own footnote marker. The edit reference dialog is designed to work on the selected text.

Event Timeline

thiemowmde renamed this task from Display edit details button in ContextItem to Display secondary edit details button in ContextItem for sub-refs.May 16 2025, 8:56 AM
awight updated the task description. (Show Details)

Change #1148874 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] Add edit button for subrefs in context item

https://gerrit.wikimedia.org/r/1148874

Change #1148874 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add edit button for subrefs in context item

https://gerrit.wikimedia.org/r/1148874

There's one aspect remaining here. Currently the "main" edit button always only opens the free form dialog. It's probably a bit work to change that. I created a ticket T395276: Open Citation Dialog when editing template main content from a subref

Change #1269999 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove fragile sub-ref button re-positioning in Minerva

https://gerrit.wikimedia.org/r/1269999

Change #1269999 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove fragile sub-ref button re-positioning in Minerva

https://gerrit.wikimedia.org/r/1269999