[S] Feature Request: Create account - Check username validity on text field return
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Tsevener
	Oct 3 2023, 1:56 PM

Project Tags

Referenced Files

	F57746110: IMG_9657.PNG
	Nov 25 2024, 6:25 PM

	F57746106: IMG_9658.PNG
	Nov 25 2024, 6:25 PM

	F57746101: 2DA395F1-BE9B-4B6C-BF27-7DCFD7EF0C23_1_102_o.jpeg
	Nov 25 2024, 6:25 PM

	F57721634: image.png
	Nov 19 2024, 2:33 PM

	F57718563: image.png
	Nov 18 2024, 7:14 PM

	F57718561: image.png
	Nov 18 2024, 7:14 PM

Subscribers

Description

I've recently downloaded and the iOS app and when trying to create a wikipedia account, I've gotten too many "username not available" errors after typing every field (especially Captcha is annoying) and tapping "Create". This frustrated me so I went to the web and tried to create an account: to my surprise, web UI checked username validity on text field return, which didn't require me to input all the fields like password.

So I've inspected the API required and implemented it in the iOS app. I couldn't find any official documentation on this API so I've just tested with 3 username types: taken, not available, and available. I'm opening this PR as a draft since I'm sure it needs some changes before being mergeable. I'm not sure the response struct I've implemented can handle all responses this API could return.

Volunteer PR in draft: https://github.com/wikimedia/wikipedia-ios/pull/4647

Related Objects

Mentioned In: T382543: Release 7.6.3
T363606: [XL] [Tech Debt] Replace custom navigation bar with system bar
Mentioned Here: T363606: [XL] [Tech Debt] Replace custom navigation bar with system bar
T376350: [S] Login / Account creation prompt

Event Timeline

Tsevener created this task.Oct 3 2023, 1:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2023, 1:56 PM

JTannerWMF triaged this task as Low priority.Oct 4 2023, 5:31 PM

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

JTannerWMF added a project: iOS Release FY2023-24 (Archive).

JTannerWMF moved this task from Tasks from Product Backlog to Needs Code Review on the iOS Release FY2023-24 (Archive) board.

Seddon moved this task from Engineering Backlog to iOS Release FY2023-24 on the Wikipedia-iOS-App-Backlog board.Mar 8 2024, 10:47 AM

Seddon edited projects, added: Wikipedia-iOS-App-Backlog (iOS Release FY2023-24); removed: Wikipedia-iOS-App-Backlog.

Seddon moved this task from Tasks from Product Backlog to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 8 2024, 10:57 AM

HNordeenWMF edited projects, added: Wikipedia-iOS-App-Backlog; removed: Wikipedia-iOS-App-Backlog (iOS Release FY2023-24).May 21 2024, 8:25 PM

HNordeenWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

Bringing this back up for discussion: if we drive folks to create accounts during Wikipedia Year in Review, this will be an important feature to have.

HNordeenWMF edited projects, added: Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed: Wikipedia-iOS-App-Backlog.Sep 24 2024, 8:40 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF moved this task from Needs Code Review to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Oct 22 2024, 9:10 PM

We should pick this up if we prompt users on Year in Review to login (currently a nice-to-have) - T376350: [S] Login / Account creation prompt

Seddon moved this task from iOS Release FY2024-25 to Product Backlog on the Wikipedia-iOS-App-Backlog board.Oct 30 2024, 9:36 PM

Seddon edited projects, added: Wikipedia-iOS-App-Backlog; removed: Wikipedia-iOS-App-Backlog (iOS Release FY2024-25).

Seddon moved this task to Up next on the Wikipedia-iOS-App-Backlog board.Oct 31 2024, 6:33 PM

HNordeenWMF edited projects, added: Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed: Wikipedia-iOS-App-Backlog.Nov 7 2024, 11:18 PM

HNordeenWMF moved this task from Blocked or Waiting to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 9 2024, 12:42 AM

Seddon moved this task from Current Sprint Work to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 12 2024, 3:36 PM

Tsevener renamed this task from Feature Request: Create account - Check username validity on text field return to [S] Feature Request: Create account - Check username validity on text field return.Nov 12 2024, 4:38 PM

HNordeenWMF moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 12 2024, 9:45 PM

HNordeenWMF moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener claimed this task.Nov 13 2024, 5:25 PM

Tsevener moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener moved this task from Doing to Design signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 13 2024, 10:31 PM

@scblr Design review build is Experimental #198.

Go to create an account screen when logged out. Type a username that is already taken. When you leave focus on the username field, an error message will appear beneath the textfield.

@Tsevener thanks for the work! some piece of feedback:

1) Can we increase the spacing so the input fields maintain their position? This is currently happening:

And here’s a rough sketch of the suggestion:

2) Just verifying: Are we using the Destructive + error color for the error and message? Seems to be a brighter red. Thanks!

• scblr moved this task from Design signoff to Did not pass design review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 18 2024, 7:16 PM

@Tsevener I realized that one of the images in T347999#10333258 wasn't attached – I hope it makes more sense now. Sorry!

Tsevener moved this task from Did not pass design review to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 21 2024, 4:45 PM

@scblr New build incoming, Experimental 7.6.3 (200).

Nice improvements @Tsevener.

1) It still jumps a tiny little bit (focus on the Passwordfield in this video:

https://share.icloud.com/photos/010uzQN1DePCmW_EnbkEuIhuQ

Any chance to eliminate these last 1-2 pixels?

2) While testing again, I noticed that the two screens are inconsistent:

`Log in`	`Create a new account`

Could you update the Create a new account navigation bar to be like the one from Log in?

3) And I don’t think the separator line is needed for both screens:

THANKS!

• scblr moved this task from Design signoff to Did not pass design review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Nov 25 2024, 6:25 PM

@scblr

It still jumps a tiny little bit (focus on the Passwordfield in this video:

I couldn't reproduce that myself, but perhaps I don't have the eye :)

I made a new Experimental build #202 that might fix this.

For 2 and 3, I would like to tackle that (navigation bar theming, lines, etc) as I work on T363606 this week.

Tsevener moved this task from Did not pass design review to Design signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Dec 3 2024, 9:35 PM

I couldn't reproduce that myself, but perhaps I don't have the eye :)

Yes, you have @Tsevener 👀 It’s fixed – thanks!

For 2 and 3, I would like to tackle that (navigation bar theming, lines, etc) as I work on T363606 this week.

Ok makes sense!

• scblr mentioned this in T363606: [XL] [Tech Debt] Replace custom navigation bar with system bar.Dec 6 2024, 12:27 PM

• scblr moved this task from Design signoff to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/5110

Tsevener removed Tsevener as the assignee of this task.Dec 9 2024, 8:46 PM

Tsevener moved this task from Needs Code Review to Needs QA signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Appears to be fixed on 7.6.3 (4669)

looks good ! I created a new account just to check that nothing is broken in that flow - works as expected.

Tsevener mentioned this in T382543: Release 7.6.3.Jan 15 2025, 5:07 PM

HNordeenWMF closed this task as Resolved.Jan 15 2025, 6:27 PM

[S] Feature Request: Create account - Check username validity on text field returnClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

[S] Feature Request: Create account - Check username validity on text field return
Closed, ResolvedPublic
Actions