Confirmation page for Special:PageTranslation?do=unmark is too generic
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	AntiCompositeNumber
	Sep 8 2021, 9:00 PM

Project Tags

Referenced Files

	F34637294: image.png
	Sep 8 2021, 9:00 PM

	F34637298: image.png
	Sep 8 2021, 9:00 PM

Subscribers

Description

List of steps to reproduce (step by step, including full links if applicable):

Cause a translatable page to be listed as broken in Special:PageTranslation
Click "Remove from translation

What happens?:
A very generic confirmation page appears. It doesn't state what action is to be confirmed, or even style the button as destructive.

What should have happened instead?:

A confirmation page explaining what action will be taken should be used, like the one for ?do=unlink

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

MediaWiki 1.37.0-alpha (48717b1) 17:17, 8 September 2021
Translate 2021-07-26 (12c07b2) 20:39, 8 September 2021

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Show more specific confirmation messages for discourage/encourage on Special:PageTranslation	mediawiki/extensions/Translate	master	+49 -44

Customize query in gerrit

Related Objects

Mentioned In: T299991: Invalid parameters in Special:PageTranslation should result in an error message
T290744: Discouraging/encouraging translation should have a confirmation step
Mentioned Here: T290744: Discouraging/encouraging translation should have a confirmation step
rMW48717b18ae24: Merge "tests: suppress API prefix uniqueness check for 'pi'"

Event Timeline

AntiCompositeNumber created this task.Sep 8 2021, 9:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2021, 9:00 PM

AntiCompositeNumber updated the task description. (Show Details)Sep 8 2021, 9:00 PM

This applies to do=discourage and do=encourage as well. And even invalid actions like do=foobar, which should result in an error message complaining about invalid parameter instead…

Aklapper added a project: Voice & Tone.Sep 9 2021, 6:01 AM

If you have JavaScript enabled, you won't see any confirmation for discourage/encourage.

The missing validation for the invalid action is clearly a bug.

Opening the encourage/discourage links in a new tab also causes the confirmation page.

In T290619#7341564, @Nikerabbit wrote:

If you have JavaScript enabled, you won't see any confirmation for discourage/encourage.

First, it doesn’t mean that the no-JS experience may be impossible to understand. There are many ways to reach it, including, but not limited to, actually having JS disabled (either intentionally or by using an ancient browser); opening the link in a new tab; or opening a direct link (posted on a discussion page, bookmarked, created using a gadget etc.).

Second, the no confirmation is actually a very bad UX in my opinion. As a beginner translation admin, I accidentally discouraged pages several times without even realizing I did something—it’s a link, which should go somewhere, not a button, which should do something. Write actions need informed user confirmation, this link is not such. (Of course, this confirmation doesn’t need to be the same as the no-JS experience; it may be for example an OOUI window, but there needs to be something.)

AntiCompositeNumber mentioned this in T290744: Discouraging/encouraging translation should have a confirmation step.Sep 10 2021, 3:24 PM

Does do-encourage and do-discourage currently have a confirmation at all or no?

Frostly mentioned this in T299991: Invalid parameters in Special:PageTranslation should result in an error message.Jan 25 2022, 4:51 AM

In T290619#7647561, @EpicPupper wrote:

Does do-encourage and do-discourage currently have a confirmation at all or no?

In the JavaScript interface, no: T290744: Discouraging/encouraging translation should have a confirmation step. In the nojs case (or when opening in a new tab) there is a generic confirmation step.

Stang subscribed.Jan 30 2022, 7:13 PM

Pppery claimed this task.Sat, May 16, 9:05 PM

Bugreporter2 awarded a token.Sun, May 17, 1:56 PM

Change #1288247 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Translate@master] Show more specific confirmation messages

https://gerrit.wikimedia.org/r/1288247

gerritbot added a project: Patch-For-Review.Sun, May 17, 8:41 PM

Nikerabbit added projects: LPL Essential (FY2025-26 Q3&4), LPL Projects (Other), Community-collaboration.Wed, May 20, 12:50 PM

Nikerabbit set the point value for this task to 1.

Change #1288247 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Show more specific confirmation messages for discourage/encourage on Special:PageTranslation

https://gerrit.wikimedia.org/r/1288247