Page MenuHomePhabricator
Create Task
Maniphest T160814

Deprecate $wgLang
Open, MediumPublic
Actions

Description

See parent task. This is a bug against core, bugs for extensions, if needed, should be subtasks of this one.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

SamanthaNguyen created this task.Mar 18 2017, 4:03 AM
SamanthaNguyen added a subtask: T160806: Remove and replace $wgLang in extensions under the social tools umbrella.Mar 18 2017, 4:06 AM
Jdforrester-WMF subscribed.Aug 13 2018, 11:10 PM
MGChecker subscribed.Sep 19 2018, 11:12 PM
Krinkle edited projects, added: Technical-Debt (Deprecation process); removed: Technical-Debt.Sep 7 2019, 5:37 PM
Krinkle moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
Krinkle subscribed.

One of the more prominent uses in core comes from ContentHandler, seen in most page views when enabling verbose logging:

[wfDebug] [DEBUG] Unstubbing $wgLang on call of $wgLang::unstub from ContentHandler->getPageLanguage

Izno mentioned this in T244383: Replace StubUserLang with a better lazy loading mechanism.Feb 6 2020, 12:20 AM
gerritbot added a comment.May 24 2020, 11:11 PM

Change 598143 had a related patch set uploaded (by Krinkle; owner: DannyS712):
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgLang

https://gerrit.wikimedia.org/r/598143

gerritbot added a project: Patch-For-Review.May 24 2020, 11:11 PM
gerritbot added a comment.May 24 2020, 11:31 PM

Change 598143 merged by jenkins-bot:
[mediawiki/core@master] ParserOptionsTest: Rename non-global variable $wgLang

https://gerrit.wikimedia.org/r/598143

DannyS712 removed a project: Patch-For-Review.May 24 2020, 11:41 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 25 2020, 12:00 AM
Krinkle added a subscriber: DannyS712.Mar 26 2021, 5:20 AM

@DannyS712 I think most if not all uses of $wgLang are basically safe to replace with something like $userLang = RequestContext::getMain()->getLanguage();. Would you be interested in giving this a try in core and/or some of the deployed extension repos?

Codesearch.

Krinkle triaged this task as Medium priority.Mar 26 2021, 5:20 AM
Krinkle edited projects, added: patch-welcome, Performance-Team (Radar); removed: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.
DannyS712 added a comment.Mar 26 2021, 2:59 PM
In T160814#6947765, @Krinkle wrote:

@DannyS712 I think most if not all uses of $wgLang are basically safe to replace with something like $userLang = RequestContext::getMain()->getLanguage();. Would you be interested in giving this a try in core and/or some of the deployed extension repos?

Codesearch.

I have a lot on my plate right now, but sure, will look into it. Deliberately *not* claiming this task yet

DannyS712 added a project: User-DannyS712.Mar 26 2021, 2:59 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Mar 26 2021, 3:00 PM

Change 674845 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/core@master] FileDeleteForm: remove use of $wgLang

https://gerrit.wikimedia.org/r/674845

gerritbot added a project: Patch-For-Review.Mar 26 2021, 3:00 PM
gerritbot added a comment.Mar 27 2021, 2:43 AM

Change 674845 merged by jenkins-bot:
[mediawiki/core@master] FileDeleteForm: Remove use of $wgLang

https://gerrit.wikimedia.org/r/674845

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 27 2021, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 27 2021, 3:10 AM
Krinkle merged a task: T244383: Replace StubUserLang with a better lazy loading mechanism.Mar 28 2021, 9:26 PM
Krinkle added subscribers: daniel, Ammarpad, Daimona and 3 others.
Nikerabbit added a comment.Jun 10 2021, 6:20 AM

Since T244383: Replace StubUserLang with a better lazy loading mechanism was closed as duplicate, I urge to increase priority of this task. StubUserLang keeps causing severe issues. Search for StubUserLang in Wikimedia-production-error yields about 20 tasks.

Ammarpad unsubscribed.Jun 17 2021, 1:06 PM
gerritbot added a comment.Aug 6 2021, 2:55 PM

Change 710570 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] FeedUtils: remove usage of $wgLang

https://gerrit.wikimedia.org/r/710570

gerritbot added a project: Patch-For-Review.Aug 6 2021, 2:55 PM
gerritbot added a comment.Aug 13 2021, 10:27 PM

Change 710570 merged by jenkins-bot:

[mediawiki/core@master] FeedUtils: remove usage of $wgLang

https://gerrit.wikimedia.org/r/710570

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 13 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 13 2021, 11:10 PM
Krinkle moved this task from Perf recommendation to Watching on the Performance-Team (Radar) board.Oct 3 2022, 9:23 PM
gerritbot added a comment.Jul 11 2023, 1:15 AM

Change 936802 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] Remove $wgLang usage from Title

https://gerrit.wikimedia.org/r/936802

gerritbot added a project: Patch-For-Review.Jul 11 2023, 1:15 AM
gerritbot added a comment.Jul 11 2023, 11:29 AM

Change 936802 merged by jenkins-bot:

[mediawiki/core@master] Remove $wgLang usage from Title

https://gerrit.wikimedia.org/r/936802

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 11:30 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 11 2023, 1:00 PM
Krinkle removed a project: Performance-Team (Radar).Aug 6 2023, 10:41 PM
Krinkle unsubscribed.
MGChecker moved this task from 2020 | MW 1.35 to Not yet on the Technical-Debt (Deprecation process) board.Feb 13 2026, 11:55 PM
gerritbot added a comment.Feb 14 2026, 5:09 PM

Change #1239481 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Disallow calling MessageCache::get with a boolean language parameter

https://gerrit.wikimedia.org/r/1239481

gerritbot added a project: Patch-For-Review.Feb 14 2026, 5:09 PM
gerritbot added a comment.Feb 14 2026, 6:49 PM

Change #1239490 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Remove reading from $wgLang from installer

https://gerrit.wikimedia.org/r/1239490

gerritbot added a comment.Feb 16 2026, 2:52 AM

Change #1239481 merged by jenkins-bot:

[mediawiki/core@master] Disallow calling MessageCache::get with a boolean language parameter

https://gerrit.wikimedia.org/r/1239481

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Feb 16 2026, 3:00 AM
gerritbot added a comment.Feb 16 2026, 3:19 AM

Change #1239560 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Deprecate calling FileRepo::getDescriptionText without lang parameter

https://gerrit.wikimedia.org/r/1239560

gerritbot added a comment.Mar 11 2026, 1:46 AM

Change #1239560 merged by jenkins-bot:

[mediawiki/core@master] Deprecate calling FileRepo::getDescriptionText without lang parameter

https://gerrit.wikimedia.org/r/1239560

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17); removed: MW-1.46-notes (1.46.0-wmf.16; 2026-02-17).Mar 11 2026, 2:00 AM
gerritbot added a comment.Mar 11 2026, 3:20 PM

Change #1250615 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Inject language into MediaHandlers rather than relying on wgLang

https://gerrit.wikimedia.org/r/1250615

MGChecker claimed this task.Mar 11 2026, 5:58 PM
gerritbot added a comment.Mar 12 2026, 2:36 AM

Change #1239490 merged by jenkins-bot:

[mediawiki/core@master] Remove reading from $wgLang from installer

https://gerrit.wikimedia.org/r/1239490

MGChecker created subtask T419848: Remove uses of $wgLang from WMF-deployed extension.Mar 12 2026, 1:50 PM
gerritbot added a comment.Mar 18 2026, 12:58 AM

Change #1254408 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Remove use of wgLang from SpecialVersion

https://gerrit.wikimedia.org/r/1254408

gerritbot added a comment.Mar 18 2026, 2:53 AM

Change #1254462 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Replace diverse wgLang reads using RequestContext

https://gerrit.wikimedia.org/r/1254462

gerritbot added a comment.Mar 24 2026, 5:20 PM

Change #1254462 merged by jenkins-bot:

[mediawiki/core@master] Replace diverse wgLang reads using RequestContext

https://gerrit.wikimedia.org/r/1254462

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31); removed: MW-1.46-notes (1.46.0-wmf.20; 2026-03-17).Mar 24 2026, 6:00 PM
gerritbot added a comment.Mar 24 2026, 9:50 PM

Change #1254408 merged by jenkins-bot:

[mediawiki/core@master] Remove use of wgLang from SpecialVersion

https://gerrit.wikimedia.org/r/1254408

MGChecker created subtask T421656: Remove $wgLang from non-WMF-deployed extensions.Mar 29 2026, 11:12 PM
Krinkle moved this task from Not yet to 2023+ | MW 1.40+ on the Technical-Debt (Deprecation process) board.Mar 30 2026, 1:49 AM
gerritbot added a comment.Apr 13 2026, 3:48 AM

Change #1250615 merged by jenkins-bot:

[mediawiki/core@master] Inject language into MediaHandlers rather than relying on wgLang

https://gerrit.wikimedia.org/r/1250615

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Apr 13 2026, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 13 2026, 4:30 AM
gerritbot added a comment.Apr 14 2026, 10:15 PM

Change #1271072 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] [DNM] Drop remaining reads from $wgLang

https://gerrit.wikimedia.org/r/1271072

gerritbot added a project: Patch-For-Review.Apr 14 2026, 10:15 PM
MGChecker added a comment.EditedApr 14 2026, 10:24 PM

Since extension code should not come into play in the installer, what do you think about trying to remove writing to wgLang there completely?

Otherwise, one of the next steps would be to have $wgLang emit deprecation warnings in 1.47, in a similar manner $wgUser did for quite a while. In WMF extensions, only a certain Wikibase service remains which does not have a fix merged or under review.

gerritbot added a comment.Apr 15 2026, 4:27 PM

Change #1271806 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] No longer write to wgLang in installer

https://gerrit.wikimedia.org/r/1271806

gerritbot added a comment.Apr 17 2026, 11:48 AM

Change #1273753 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Replace use of $wgLang in test code

https://gerrit.wikimedia.org/r/1273753

gerritbot added a comment.Apr 17 2026, 2:53 PM

Change #1273753 merged by jenkins-bot:

[mediawiki/core@master] Replace use of $wgLang in test code

https://gerrit.wikimedia.org/r/1273753

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28); removed: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 17 2026, 3:00 PM
gerritbot added a comment.May 5 2026, 2:18 AM

Change #1271072 merged by jenkins-bot:

[mediawiki/core@master] Drop remaining reads from $wgLang and deprecate

https://gerrit.wikimedia.org/r/1271072

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).May 5 2026, 3:00 AM
gerritbot added a comment.May 5 2026, 11:22 PM

Change #1271806 merged by jenkins-bot:

[mediawiki/core@master] No longer write to wgLang in installer

https://gerrit.wikimedia.org/r/1271806

Maintenance_bot removed a project: Patch-For-Review.May 5 2026, 11:30 PM
MGChecker added a comment.May 7 2026, 8:34 AM

The soft-deprecation is now completed: There are no more callsites in core, a single, trickier one in a wmf-deployed extension for which a change is awaiting review, and the next version of codesniffer will include a rule against global

This only leaves emitting warnings (which is somewhat fiddly for globals...), before eventual removal in MW 1.5X.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits