Skip to content

Apply design team decisions - #84

Merged
tireddy2 merged 28 commits into
mainfrom
mbj-design-team
Nov 29, 2025
Merged

Apply design team decisions#84
tireddy2 merged 28 commits into
mainfrom
mbj-design-team

Conversation

@selfissued

@selfissued selfissued commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

This PR will apply the design team decisions from 5-Nov-25 at IETF 124 in Montreal. Those decisions were to:

  • Not use "enc" when performing Integrated Encryption.
  • Define one new Key Management Mode for Integrated Encryption.
  • Integrate the new mode into the Message Encryption and Message Decryption instructions from RFC 7516 and replace them.
  • Utilize distinct algorithm identifiers for the use of HPKE for Integrated Encryption and HPKE for Key Encryption.
  • Only use the Recipient_structure when doing Key Encryption and not when doing Integrated Encryption.

Fixes #42
Fixes #77
Fixes #79

Replaces #83

(The initial commit adds the baseline Message Encryption and Message Decryption instructions without modification (other than conversion from XML to Markdown) so that future commits will make it obvious what the deltas to the instructions in RFC 7516 are.)

Cc: @bc-pi @panva @dwaite @leifj @paulbastian @jogu @kodonog @debcooley

@selfissued
selfissued marked this pull request as draft November 6, 2025 15:43
@panva

panva commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

@selfissued one missing decision from your bullet point list

  • designate distinct "alg" values for Integrated Encryption and Key Encryption modes, e.g. HPKE-0 for IE and HPKE-0+KE for KE (actual values TBD, i'll leave those for the authors to propose)

@selfissued

Copy link
Copy Markdown
Collaborator Author

Good catch @panva, where you said:

@selfissued one missing decision from your bullet point list

designate distinct "alg" values for Integrated Encryption and Key Encryption modes, e.g. HPKE-0 for IE and HPKE-0+KE for KE (actual values TBD, i'll leave those for the authors to propose)

I've edited the PR description to add this decision to the list.

Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
@hannestschofenig

Copy link
Copy Markdown
Collaborator

Thank you Mike for the super-quick response on this issue! Give me time over the weekend to review the new PR!

Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
@selfissued

Copy link
Copy Markdown
Collaborator Author

@hannestschofenig I would suggest waiting to review the PR until I've completed it. The initial commit does not instantiate the design team decisions. The primary text change in the PR is to add the baseline Message Encryption and Message Decryption instructions from Sections 5.1 and 5.2 of RFC 7516 without modification (other than conversion from XML to Markdown) so that future commits will make it obvious what the deltas to the instructions this specification introduces are.)

selfissued and others added 2 commits November 10, 2025 10:35
@selfissued
selfissued marked this pull request as ready for review November 26, 2025 01:08
@selfissued

Copy link
Copy Markdown
Collaborator Author

For your reviewing pleasure, a rendered version of this PR is available at https://self-issued.info/tmp/draft-ietf-jose-hpke-encrypt.html

Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Comment thread draft-ietf-jose-hpke-encrypt.md
Comment thread draft-ietf-jose-hpke-encrypt.md
Comment thread draft-ietf-jose-hpke-encrypt.md
Comment thread draft-ietf-jose-hpke-encrypt.md
@ilaril

ilaril commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

Since this construction does not seem to be named, how should another draft that adds a new cipher suite reference the procedures — especially HPKE in Key Encryption / Integrated Encryption — defined in this draft? Repeating the procedures risks divergences, which are very much undesirable.

E.g., how should the two cipher suites with KDF=0x647a (X-Wing), KDF=0x0011 (SHAKE256), AEAD=0x0002 (AES-256-GCM) be defined?

Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Co-authored-by: Tirumaleswar Reddy <30891538+tireddy2@users.noreply.github.com>
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
Comment thread draft-ietf-jose-hpke-encrypt.md
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
@panva

panva commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

I propose to add a section with a summary of all 7516 updates

# Summary of Updates to RFC 7516

This specification updates JSON Web Encryption (JWE) {{RFC7516}} as follows:

- Adds the Integrated Encryption Key Management Mode and
  updates the definition of Key Management Mode ({{terminology}}).

- Updates the "enc" header parameter to be absent when
  Integrated Encryption is used ({{overview}}).

- Replaces the Message Encryption procedure ({{encryption}}).

- Replaces the Message Decryption procedure ({{decryption}}).

- Updates the methods for distinguishing between JWS and JWE objects
  ({{needs-an-anchor}}).

tireddy2 and others added 2 commits November 28, 2025 15:53
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
Comment thread draft-ietf-jose-hpke-encrypt.md
Comment thread draft-ietf-jose-hpke-encrypt.md
Comment thread draft-ietf-jose-hpke-encrypt.md Outdated
selfissued and others added 2 commits November 28, 2025 08:36
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
@selfissued

Copy link
Copy Markdown
Collaborator Author

The summary was added. The rendered draft at https://self-issued.info/tmp/draft-ietf-jose-hpke-encrypt.html been updated.

@tireddy2
tireddy2 merged commit 1f93f0d into main Nov 29, 2025
2 checks passed
@konginit

Copy link
Copy Markdown

This PR will apply the design team decisions from 5-Nov-25 at IETF 124 in Montreal. Those decisions were to:

  • Not use "enc" when performing Integrated Encryption.
  • Define one new Key Management Mode for Integrated Encryption.
  • Integrate the new mode into the Message Encryption and Message Decryption instructions from RFC 7516 and replace them.
  • Utilize distinct algorithm identifiers for the use of HPKE for Integrated Encryption and HPKE for Key Encryption.
  • Only use the Recipient_structure when doing Key Encryption and not when doing Integrated Encryption.

Fixes #42
Fixes #77
Fixes #79

Replaces #83

(The initial commit adds the baseline Message Encryption and Message Decryption instructions without modification (other than conversion from XML to Markdown) so that future commits will make it obvious what the deltas to the instructions in RFC 7516 are.)

Cc: @bc-pi @panva @dwaite @leifj @paulbastian @jogu @kodonog @debcooley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can we do better? Stabilize/rationalize/progress the work a null JWE content encryption algorithm is dangerous regardless of name

8 participants