Fix TypeScript breakages by specifying types for overridden setAttribute and getAttribute.

bicknellr · bicknellr · commit c8715b50b906 · 2020-04-27T18:35:14.000-07:00
diff --git a/lib/legacy/legacy-element-mixin.js b/lib/legacy/legacy-element-mixin.js
@@ -143,7 +143,11 @@ export const LegacyElementMixin = dedupingMixin((base) => {
       }
     }
 
-    /** @override */
+    /**
+     * @override
+     * @param {string} name
+     * @param {string} value
+     */
     setAttribute(name, value) {
       if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
         const oldValue = this.getAttribute(name);
@@ -155,7 +159,10 @@ export const LegacyElementMixin = dedupingMixin((base) => {
       }
     }
 
-    /** @override */
+    /**
+     * @override
+     * @param {string} name
+     */
     removeAttribute(name) {
       if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
         const oldValue = this.getAttribute(name);

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,11 @@ export const LegacyElementMixin = dedupingMixin((base) => {`
`143`	`143`	`}`
`144`	`144`	`}`
`145`	`145`
`146`		`- /** @override */`
	`146`	`+ /**`
	`147`	`+ * @override`
	`148`	`+ * @param {string} name`
	`149`	`+ * @param {string} value`
	`150`	`+ */`
`147`	`151`	`setAttribute(name, value) {`
`148`	`152`	`if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {`
`149`	`153`	`const oldValue = this.getAttribute(name);`
`@@ -155,7 +159,10 @@ export const LegacyElementMixin = dedupingMixin((base) => {`
`155`	`159`	`}`
`156`	`160`	`}`
`157`	`161`
`158`		`- /** @override */`
	`162`	`+ /**`
	`163`	`+ * @override`
	`164`	`+ * @param {string} name`
	`165`	`+ */`
`159`	`166`	`removeAttribute(name) {`
`160`	`167`	`if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {`
`161`	`168`	`const oldValue = this.getAttribute(name);`